Convert WebSecurityOrigin -> GURL without re-parsing the url

Convert WebSecurityOrigin -> GURL without re-parsing the url

BUG=651554
Committed: https://crrev.com/d88f975e033692c119c62373f3782875fad40115
Cr-Commit-Position: refs/heads/master@{#427884}

[Charlie Harrison, 2016-09-30 03:22:45]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 03:22:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 05:17:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 05:17:32]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2016-10-04 03:32:49]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 03:33:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 03:36:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 03:36:08]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Charlie Harrison, 2016-10-04 03:55:39]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 03:55:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-10-04 04:09:25]

csharrison@chromium.org changed reviewers:
+ esprehn@chromium.org, hubbe@chromium.org, thakis@chromium.org

[Charlie Harrison, 2016-10-04 04:09:26]

Hi all,
We now have a way to get GURLs from Origins without serializing + re-parsing the
URL. This CL does that for WebSecurityOrigins.

esprehn: ptal at content/renderer, content/child, and Blink
hubbe: ptal at media/blink
thakis: ptal at chrome/renderer

Thanks!

[commit-bot: I haz the power, 2016-10-04 05:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 05:06:49]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-10-08 03:36:24]

lgtm

https://codereview.chromium.org/2382973002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/storage/StorageNamespace.cpp (right):

https://codereview.chromium.org/2382973002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/storage/StorageNamespace.cpp:52:
localStorageNamespace->createStorageArea(WebSecurityOrigin(origin))),
Does WebSecurityOrigin not implicitly convert? I think you can just pass origin

[dcheng, 2016-10-08 06:18:11]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-10-08 06:18:12]

Out of curiosity, can we disallow people from writing
WebStringToGURL(wso->toString()) by removing WebSecurityOrigin::toString()
completely in a followup?

[Charlie Harrison, 2016-10-08 14:24:35]

We can almost do that, but we may need to have a WebSecurityOrigin -> KURL
method too.

I'll try to clean up loose ends after this patch lands.

Note: unfortunately WebSecurityOrigin->Origin conversions are still a bit
expensive (not quite as expensive as origin->string->GURL) until 
https://codereview.chromium.org/2391383003/ lands due to us re-canonicalizing
the host.

[Charlie Harrison, 2016-10-09 02:40:12]

https://codereview.chromium.org/2382973002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/storage/StorageNamespace.cpp (right):

https://codereview.chromium.org/2382973002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/storage/StorageNamespace.cpp:52:
localStorageNamespace->createStorageArea(WebSecurityOrigin(origin))),
On 2016/10/08 03:36:23, esprehn wrote:
> Does WebSecurityOrigin not implicitly convert? I think you can just pass
origin

No it doesn't implicitly convert. My C++ foo isn't strong enough to know why
exactly:
"reference to type 'const blink::WebSecurityOrigin' could not bind to an lvalue
of type 'blink::SecurityOrigin *'"

We do have a non-explicit constructor that takes a PassRefPtr<SecurityOrigin>...

[Charlie Harrison, 2016-10-18 13:42:18]

csharrison@chromium.org changed reviewers:
+ thestig@chromium.org
- thakis@chromium.org

[Charlie Harrison, 2016-10-18 13:42:19]

-thakis, +thestig could you please look at chrome/renderer?

hubbe, friendly ping for media/blink.

[Lei Zhang, 2016-10-18 16:40:26]

lgtm!

[Charlie Harrison, 2016-10-24 18:29:10]

hubbe, friendly ping

[hubbe, 2016-10-24 18:34:29]

media/blink LGTM

[Charlie Harrison, 2016-10-24 18:38:06]

Thanks! sending to CQ in 3...2...1..

[Charlie Harrison, 2016-10-24 18:38:29]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2016-10-24 18:39:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 18:43:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 18:43:15]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Charlie Harrison, 2016-10-24 20:13:46]

The CQ bit was checked by csharrison@chromium.org

[Charlie Harrison, 2016-10-24 20:13:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, esprehn@chromium.org, hubbe@chromium.org
Link to the patchset: https://codereview.chromium.org/2382973002/#ps60001
(title: "rebase on #427122")

[commit-bot: I haz the power, 2016-10-24 20:14:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 22:13:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 22:13:10]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Charlie Harrison, 2016-10-25 04:36:44]

I think something might be wrong here with url::Origins not preserving
SubOrigins. Let's hold off for a minute on landing this.

[Charlie Harrison, 2016-10-26 22:25:23]

jww@ has graciously fixed the problem here, where we weren't properly threading
suborigins through WebSecurityOrigin. Let's try landing now that that fix has (
https://codereview.chromium.org/2449233002/)

[Charlie Harrison, 2016-10-26 22:25:32]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2016-10-26 22:26:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 23:57:07]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-27 00:00:48]

Description was changed from

==========
Convert WebSecurityOrigin -> GURL without re-parsing the url

BUG=651554
==========

to

==========
Convert WebSecurityOrigin -> GURL without re-parsing the url

BUG=651554

Committed: https://crrev.com/d88f975e033692c119c62373f3782875fad40115
Cr-Commit-Position: refs/heads/master@{#427884}
==========

[commit-bot: I haz the power, 2016-10-27 00:00:50]

Patchset 4 (id:??) landed as
https://crrev.com/d88f975e033692c119c62373f3782875fad40115
Cr-Commit-Position: refs/heads/master@{#427884}