ui/base/test/use_interactive_test_case.h - Issue 2382963002: Views: Add two disabled tests for invoking the CC unmask prompt dialog.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/base/test/use_interactive_test_case.h

Issue 2382963002: Views: Add two disabled tests for invoking the CC unmask prompt dialog. (Closed)

Patch Set: Review comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_BASE_TEST_USE_INTERACTIVE_TEST_CASE_H_

	6 #define UI_BASE_TEST_USE_INTERACTIVE_TEST_CASE_H_

	7

	8 namespace test {

	9

	10 // Foregrounds the test process and spins a run loop to run a test case as

	11 // interactive UI. Call this at the end of test fixtures that are used to

	12 // invoke UI (designed for manual testing of hard-to-summon dialogs).
	tapted 2016/10/17 23:44:51 This comment is good. I think we just need a sente This comment is good. I think we just need a sentence like "This function does not return." (We pass in a base::Closure* quit that could allow a test case to quit the run loop, but that requires extra plumbing). Patti Lor 2016/10/18 03:44:26 Done. I think not doing the quit thing is fine too Show quoted text On 2016/10/17 23:44:51, tapted wrote: > This comment is good. I think we just need a sentence like > > "This function does not return." > > > (We pass in a base::Closure* quit that could allow a test case to quit the run > loop, but that requires extra plumbing). Done. I think not doing the quit thing is fine too, since \|exit_when_last_browser_closes_\| is true by default.
	13 void RunTestInteractively();

	14 }
	tapted 2016/10/17 23:44:51 nit: blank line before + " // namespace test" nit: blank line before + " // namespace test" Patti Lor 2016/10/18 03:44:26 Done. Show quoted text On 2016/10/17 23:44:51, tapted wrote: > nit: blank line before + " // namespace test" Done.
	15

	16 #endif // UI_BASE_TEST_USE_INTERACTIVE_TEST_CASE_H_

OLD	NEW

« chrome/test/BUILD.gn ('K') | « chrome/test/BUILD.gn ('k') | ui/base/test/use_interactive_test_case.cc » ('j') | ui/base/test/use_interactive_test_case.cc » ('J')