ui/base/test/use_interactive_test_case.cc - Issue 2382963002: Views: Add two disabled tests for invoking the CC unmask prompt dialog.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/base/test/use_interactive_test_case.cc

Issue 2382963002: Views: Add two disabled tests for invoking the CC unmask prompt dialog. (Closed)

Patch Set: Review comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ui/base/test/use_interactive_test_case.h ('K') | « ui/base/test/use_interactive_test_case.h ('k') | ui/base/test/use_interactive_test_case_mac.mm » ('j') | ui/base/test/use_interactive_test_case_mac.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ui/base/test/use_interactive_test_case.h"
	tapted 2016/10/17 23:44:50 oh dang-it - my review comment had a typo :(. I me oh dang-it - my review comment had a typo :(. I meant "user_interactive_test_case.h" (i.e. to distinguish it from interactive_ui_test). Patti Lor 2016/10/18 03:44:26 No worries, done :) Show quoted text On 2016/10/17 23:44:50, tapted wrote: > oh dang-it - my review comment had a typo :(. I meant > "user_interactive_test_case.h" (i.e. to distinguish it from > interactive_ui_test). No worries, done :)
	6

	7 #include "base/run_loop.h"

	8

	9 namespace test {

	10

	11 #if !defined(OS_MACOSX)
	tapted 2016/10/17 23:44:50 per the BUILD.gn comment (and because of ios) I th per the BUILD.gn comment (and because of ios) I think we need to remove this guard and pick the implementation file in the .gn instead Patti Lor 2016/10/18 03:44:26 Done. Show quoted text On 2016/10/17 23:44:50, tapted wrote: > per the BUILD.gn comment (and because of ios) I think we need to remove this > guard and pick the implementation file in the .gn instead Done.
	12 void RunTestInteractively() {

	13 base::RunLoop().Run();

	14 }

	15 #endif

	16 }
	tapted 2016/10/17 23:44:50 nit: blank line before + " // namespace test" nit: blank line before + " // namespace test" Patti Lor 2016/10/18 03:44:26 Oops, sorry about these - git cl format deleted th Show quoted text On 2016/10/17 23:44:50, tapted wrote: > nit: blank line before + " // namespace test" Oops, sorry about these - git cl format deleted them I think. Done.
OLD	NEW