chrome/test/base/move_test_process_to_front_mac.mm - Issue 2382963002: Views: Add two disabled tests for invoking the CC unmask prompt dialog.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/base/move_test_process_to_front_mac.mm

Issue 2382963002: Views: Add two disabled tests for invoking the CC unmask prompt dialog. (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include <Cocoa/Cocoa.h>

	6

	7 void SetProcessToFront() {

	8 ProcessSerialNumber psn = {0, kCurrentProcess};

	9 TransformProcessType(&psn, kProcessTransformToForegroundApplication);
	tapted 2016/10/16 23:48:01 I'm pretty sure this duplicates what [NSApp setAct I'm pretty sure this duplicates what [NSApp setActivationPolicy:NSApplicationActivationPolicyRegular]; does. But then since it's just 1-2 lines, I don't think we need SetProcessToFront. Let's not change interactive_test_utils_mac.mm for now. We can remove the SetProcessToFront() from RunTestInteractively(), and just do [NSApp setActivationPolicy:NSApplicationActivationPolicyRegular]; [NSApp activateIgnoringOtherApps:YES]; Patti Lor 2016/10/17 23:26:09 Done. Show quoted text On 2016/10/16 23:48:01, tapted wrote: > I'm pretty sure this duplicates what [NSApp > setActivationPolicy:NSApplicationActivationPolicyRegular]; does. But then since > it's just 1-2 lines, I don't think we need SetProcessToFront. Let's not change > interactive_test_utils_mac.mm for now. > > We can remove the SetProcessToFront() from RunTestInteractively(), and just do > > [NSApp setActivationPolicy:NSApplicationActivationPolicyRegular]; > [NSApp activateIgnoringOtherApps:YES]; > Done.
	10 [[NSApplication sharedApplication] activateIgnoringOtherApps:YES];

	11 }

OLD	NEW