Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 2382953004: Revert "Lazy deopt without code patching." (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/instructions_arm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_x64.cc
diff --git a/runtime/vm/flow_graph_compiler_x64.cc b/runtime/vm/flow_graph_compiler_x64.cc
index 021ed5150acd54e53afa3afdc576d767e706f9fa..c56c320e81bec958b8f71a8122ecd0effe722d16 100644
--- a/runtime/vm/flow_graph_compiler_x64.cc
+++ b/runtime/vm/flow_graph_compiler_x64.cc
@@ -1123,6 +1123,19 @@ void FlowGraphCompiler::CompileGraph() {
__ int3();
ASSERT(assembler()->constant_pool_allowed());
GenerateDeferredCode();
+ // Emit function patching code. This will be swapped with the first 13 bytes
+ // at entry point.
+
+ BeginCodeSourceRange();
+ if (is_optimizing() && !FLAG_precompiled_mode) {
+ // Leave enough space for patching in case of lazy deoptimization.
+ __ nop(ShortCallPattern::pattern_length_in_bytes());
+ lazy_deopt_return_pc_offset_ = assembler()->CodeSize();
+ __ Jmp(*StubCode::DeoptimizeLazyFromReturn_entry(), PP);
+ lazy_deopt_throw_pc_offset_ = assembler()->CodeSize();
+ __ Jmp(*StubCode::DeoptimizeLazyFromThrow_entry(), PP);
+ }
+ EndCodeSourceRange(TokenPosition::kDartCodeEpilogue);
}
« no previous file with comments | « runtime/vm/flow_graph_compiler_mips.cc ('k') | runtime/vm/instructions_arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698