Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Side by Side Diff: runtime/vm/isolate.cc

Issue 2382953004: Revert "Lazy deopt without code patching." (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/isolate.h" 5 #include "vm/isolate.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "include/dart_native_api.h" 8 #include "include/dart_native_api.h"
9 #include "platform/assert.h" 9 #include "platform/assert.h"
10 #include "platform/text_buffer.h" 10 #include "platform/text_buffer.h"
(...skipping 795 matching lines...) Expand 10 before | Expand all | Expand 10 after
806 symbols_mutex_(new Mutex()), 806 symbols_mutex_(new Mutex()),
807 type_canonicalization_mutex_(new Mutex()), 807 type_canonicalization_mutex_(new Mutex()),
808 constant_canonicalization_mutex_(new Mutex()), 808 constant_canonicalization_mutex_(new Mutex()),
809 megamorphic_lookup_mutex_(new Mutex()), 809 megamorphic_lookup_mutex_(new Mutex()),
810 message_handler_(NULL), 810 message_handler_(NULL),
811 spawn_state_(NULL), 811 spawn_state_(NULL),
812 is_runnable_(false), 812 is_runnable_(false),
813 gc_prologue_callback_(NULL), 813 gc_prologue_callback_(NULL),
814 gc_epilogue_callback_(NULL), 814 gc_epilogue_callback_(NULL),
815 defer_finalization_count_(0), 815 defer_finalization_count_(0),
816 pending_deopts_(new MallocGrowableArray<PendingLazyDeopt>),
817 deopt_context_(NULL), 816 deopt_context_(NULL),
818 is_service_isolate_(false), 817 is_service_isolate_(false),
819 stacktrace_(NULL), 818 stacktrace_(NULL),
820 stack_frame_index_(-1), 819 stack_frame_index_(-1),
821 last_allocationprofile_accumulator_reset_timestamp_(0), 820 last_allocationprofile_accumulator_reset_timestamp_(0),
822 last_allocationprofile_gc_timestamp_(0), 821 last_allocationprofile_gc_timestamp_(0),
823 object_id_ring_(NULL), 822 object_id_ring_(NULL),
824 tag_table_(GrowableObjectArray::null()), 823 tag_table_(GrowableObjectArray::null()),
825 deoptimized_code_array_(GrowableObjectArray::null()), 824 deoptimized_code_array_(GrowableObjectArray::null()),
826 sticky_error_(Error::null()), 825 sticky_error_(Error::null()),
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
872 delete mutex_; 871 delete mutex_;
873 mutex_ = NULL; // Fail fast if interrupts are scheduled on a dead isolate. 872 mutex_ = NULL; // Fail fast if interrupts are scheduled on a dead isolate.
874 delete symbols_mutex_; 873 delete symbols_mutex_;
875 symbols_mutex_ = NULL; 874 symbols_mutex_ = NULL;
876 delete type_canonicalization_mutex_; 875 delete type_canonicalization_mutex_;
877 type_canonicalization_mutex_ = NULL; 876 type_canonicalization_mutex_ = NULL;
878 delete constant_canonicalization_mutex_; 877 delete constant_canonicalization_mutex_;
879 constant_canonicalization_mutex_ = NULL; 878 constant_canonicalization_mutex_ = NULL;
880 delete megamorphic_lookup_mutex_; 879 delete megamorphic_lookup_mutex_;
881 megamorphic_lookup_mutex_ = NULL; 880 megamorphic_lookup_mutex_ = NULL;
882 delete pending_deopts_;
883 pending_deopts_ = NULL;
884 delete message_handler_; 881 delete message_handler_;
885 message_handler_ = NULL; // Fail fast if we send messages to a dead isolate. 882 message_handler_ = NULL; // Fail fast if we send messages to a dead isolate.
886 ASSERT(deopt_context_ == NULL); // No deopt in progress when isolate deleted. 883 ASSERT(deopt_context_ == NULL); // No deopt in progress when isolate deleted.
887 delete spawn_state_; 884 delete spawn_state_;
888 #ifndef PRODUCT 885 #ifndef PRODUCT
889 if (FLAG_support_service) { 886 if (FLAG_support_service) {
890 delete object_id_ring_; 887 delete object_id_ring_;
891 } 888 }
892 #endif // !PRODUCT 889 #endif // !PRODUCT
893 object_id_ring_ = NULL; 890 object_id_ring_ = NULL;
(...skipping 2009 matching lines...) Expand 10 before | Expand all | Expand 10 after
2903 void IsolateSpawnState::DecrementSpawnCount() { 2900 void IsolateSpawnState::DecrementSpawnCount() {
2904 ASSERT(spawn_count_monitor_ != NULL); 2901 ASSERT(spawn_count_monitor_ != NULL);
2905 ASSERT(spawn_count_ != NULL); 2902 ASSERT(spawn_count_ != NULL);
2906 MonitorLocker ml(spawn_count_monitor_); 2903 MonitorLocker ml(spawn_count_monitor_);
2907 ASSERT(*spawn_count_ > 0); 2904 ASSERT(*spawn_count_ > 0);
2908 *spawn_count_ = *spawn_count_ - 1; 2905 *spawn_count_ = *spawn_count_ - 1;
2909 ml.Notify(); 2906 ml.Notify();
2910 } 2907 }
2911 2908
2912 } // namespace dart 2909 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698