Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1733)

Side by Side Diff: runtime/vm/intermediate_language_arm64.cc

Issue 2382953004: Revert "Lazy deopt without code patching." (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 2536 matching lines...) Expand 10 before | Expand all | Expand 10 after
2547 2547
2548 2548
2549 LocationSummary* CatchBlockEntryInstr::MakeLocationSummary(Zone* zone, 2549 LocationSummary* CatchBlockEntryInstr::MakeLocationSummary(Zone* zone,
2550 bool opt) const { 2550 bool opt) const {
2551 UNREACHABLE(); 2551 UNREACHABLE();
2552 return NULL; 2552 return NULL;
2553 } 2553 }
2554 2554
2555 2555
2556 void CatchBlockEntryInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 2556 void CatchBlockEntryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
2557 // Ensure space for patching return sites for lazy deopt.
2558 if (!FLAG_precompiled_mode && compiler->is_optimizing()) {
2559 for (intptr_t i = 0;
2560 i < CallPattern::kDeoptCallLengthInInstructions;
2561 ++i) {
2562 __ orr(R0, ZR, Operand(R0)); // nop
2563 }
2564 }
2557 __ Bind(compiler->GetJumpLabel(this)); 2565 __ Bind(compiler->GetJumpLabel(this));
2558 compiler->AddExceptionHandler(catch_try_index(), 2566 compiler->AddExceptionHandler(catch_try_index(),
2559 try_index(), 2567 try_index(),
2560 compiler->assembler()->CodeSize(), 2568 compiler->assembler()->CodeSize(),
2561 catch_handler_types_, 2569 catch_handler_types_,
2562 needs_stacktrace()); 2570 needs_stacktrace());
2563 // On lazy deoptimization we patch the optimized code here to enter the 2571 // On lazy deoptimization we patch the optimized code here to enter the
2564 // deoptimization stub. 2572 // deoptimization stub.
2565 const intptr_t deopt_id = Thread::ToDeoptAfter(GetDeoptId()); 2573 const intptr_t deopt_id = Thread::ToDeoptAfter(GetDeoptId());
2566 if (compiler->is_optimizing()) { 2574 if (compiler->is_optimizing()) {
(...skipping 3212 matching lines...) Expand 10 before | Expand all | Expand 10 after
5779 1, 5787 1,
5780 locs()); 5788 locs());
5781 __ Drop(1); 5789 __ Drop(1);
5782 __ Pop(result); 5790 __ Pop(result);
5783 } 5791 }
5784 5792
5785 5793
5786 } // namespace dart 5794 } // namespace dart
5787 5795
5788 #endif // defined TARGET_ARCH_ARM64 5796 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698