Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 2382953004: Revert "Lazy deopt without code patching." (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/instructions_x64.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 2819 matching lines...) Expand 10 before | Expand all | Expand 10 after
2830 2830
2831 2831
2832 LocationSummary* CatchBlockEntryInstr::MakeLocationSummary(Zone* zone, 2832 LocationSummary* CatchBlockEntryInstr::MakeLocationSummary(Zone* zone,
2833 bool opt) const { 2833 bool opt) const {
2834 UNREACHABLE(); 2834 UNREACHABLE();
2835 return NULL; 2835 return NULL;
2836 } 2836 }
2837 2837
2838 2838
2839 void CatchBlockEntryInstr::EmitNativeCode(FlowGraphCompiler* compiler) { 2839 void CatchBlockEntryInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
2840 // Ensure space for patching return sites for lazy deopt.
2841 if (!FLAG_precompiled_mode && compiler->is_optimizing()) {
2842 for (intptr_t i = 0;
2843 i < CallPattern::DeoptCallPatternLengthInInstructions();
2844 ++i) {
2845 __ nop();
2846 }
2847 }
2840 __ Bind(compiler->GetJumpLabel(this)); 2848 __ Bind(compiler->GetJumpLabel(this));
2841 compiler->AddExceptionHandler(catch_try_index(), 2849 compiler->AddExceptionHandler(catch_try_index(),
2842 try_index(), 2850 try_index(),
2843 compiler->assembler()->CodeSize(), 2851 compiler->assembler()->CodeSize(),
2844 catch_handler_types_, 2852 catch_handler_types_,
2845 needs_stacktrace()); 2853 needs_stacktrace());
2846 // On lazy deoptimization we patch the optimized code here to enter the 2854 // On lazy deoptimization we patch the optimized code here to enter the
2847 // deoptimization stub. 2855 // deoptimization stub.
2848 const intptr_t deopt_id = Thread::ToDeoptAfter(GetDeoptId()); 2856 const intptr_t deopt_id = Thread::ToDeoptAfter(GetDeoptId());
2849 if (compiler->is_optimizing()) { 2857 if (compiler->is_optimizing()) {
(...skipping 4142 matching lines...) Expand 10 before | Expand all | Expand 10 after
6992 1, 7000 1,
6993 locs()); 7001 locs());
6994 __ Drop(1); 7002 __ Drop(1);
6995 __ Pop(result); 7003 __ Pop(result);
6996 } 7004 }
6997 7005
6998 7006
6999 } // namespace dart 7007 } // namespace dart
7000 7008
7001 #endif // defined TARGET_ARCH_ARM 7009 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/instructions_x64.cc ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698