Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 2382953004: Revert "Lazy deopt without code patching." (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 1094 matching lines...) Expand 10 before | Expand all | Expand 10 after
1105 } 1105 }
1106 } 1106 }
1107 } 1107 }
1108 1108
1109 EndCodeSourceRange(TokenPosition::kDartCodePrologue); 1109 EndCodeSourceRange(TokenPosition::kDartCodePrologue);
1110 VisitBlocks(); 1110 VisitBlocks();
1111 1111
1112 __ bkpt(0); 1112 __ bkpt(0);
1113 ASSERT(assembler()->constant_pool_allowed()); 1113 ASSERT(assembler()->constant_pool_allowed());
1114 GenerateDeferredCode(); 1114 GenerateDeferredCode();
1115
1116 BeginCodeSourceRange();
1117 if (is_optimizing() && !FLAG_precompiled_mode) {
1118 // Leave enough space for patching in case of lazy deoptimization.
1119 for (intptr_t i = 0;
1120 i < CallPattern::DeoptCallPatternLengthInInstructions();
1121 ++i) {
1122 __ nop();
1123 }
1124 lazy_deopt_return_pc_offset_ = assembler()->CodeSize();
1125 __ Branch(*StubCode::DeoptimizeLazyFromReturn_entry());
1126 lazy_deopt_throw_pc_offset_ = assembler()->CodeSize();
1127 __ Branch(*StubCode::DeoptimizeLazyFromThrow_entry());
1128 }
1129 EndCodeSourceRange(TokenPosition::kDartCodeEpilogue);
1115 } 1130 }
1116 1131
1117 1132
1118 void FlowGraphCompiler::GenerateCall(TokenPosition token_pos, 1133 void FlowGraphCompiler::GenerateCall(TokenPosition token_pos,
1119 const StubEntry& stub_entry, 1134 const StubEntry& stub_entry,
1120 RawPcDescriptors::Kind kind, 1135 RawPcDescriptors::Kind kind,
1121 LocationSummary* locs) { 1136 LocationSummary* locs) {
1122 __ BranchLinkPatchable(stub_entry); 1137 __ BranchLinkPatchable(stub_entry);
1123 AddCurrentDescriptor(kind, Thread::kNoDeoptId, token_pos); 1138 AddCurrentDescriptor(kind, Thread::kNoDeoptId, token_pos);
1124 RecordSafepoint(locs); 1139 RecordSafepoint(locs);
(...skipping 845 matching lines...) Expand 10 before | Expand all | Expand 10 after
1970 DRegister dreg = EvenDRegisterOf(reg); 1985 DRegister dreg = EvenDRegisterOf(reg);
1971 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex)); 1986 __ vldrd(dreg, Address(SP, kDoubleSize, Address::PostIndex));
1972 } 1987 }
1973 1988
1974 1989
1975 #undef __ 1990 #undef __
1976 1991
1977 } // namespace dart 1992 } // namespace dart
1978 1993
1979 #endif // defined TARGET_ARCH_ARM 1994 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698