Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3173)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html

Issue 2382943002: MD Settings: Migrating add/edit address dropdowns to native select. (Closed)
Patch Set: Addressing comment. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html b/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
index 0744e08e4b87e44463f1eb47942250a980ac5d78..dbbbc0bec8a7b112f022d99c2c04cdcf3a86e8fe 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
@@ -2,15 +2,14 @@
<link rel="import" href="chrome://resources/html/cr.html">
<link rel="import" href="chrome://resources/html/i18n_behavior.html">
<link rel="import" href="chrome://resources/html/polymer.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/paper-dropdown-menu-light.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-textarea.html">
-<link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-listbox.html">
<link rel="import" href="/settings_shared_css.html">
+<link rel="import" href="/select_css.html">
<dom-module id="settings-address-edit-dialog">
<template>
- <style include="settings-shared">
+ <style include="settings-shared select">
.address-row {
display: flex;
}
@@ -21,6 +20,20 @@
width: calc((var(--paper-input-max-width) - 16px) / 2);
}
+ select.address-column {
+ -webkit-margin-end: 0;
+ margin-bottom: 0;
+ }
+
+ #select-row {
+ display: block;
+ }
+
+ #select-label {
+ color: var(--light-theme-secondary-color);
+ font-size: 12px
+ }
+
.long {
width: var(--paper-input-max-width);
}
@@ -60,21 +73,21 @@
</template>
</div>
</template>
- <div class="address-row">
- <paper-dropdown-menu-light class="country-dropdown address-column long"
- vertical-align="auto"
- on-value-changed="updateCanSave_" label="$i18n{addressCountry}"
- always-float-label>
- <paper-listbox id="countryList" class="dropdown-content"
- selected="{{countryCode_}}" attr-for-selected="code">
+ <div id="select-row" class="address-row">
+ <div id="select-label">$i18n{addressCountry}</div>
+ <span class="select-wrapper">
+ <select class="address-column long" value="[[countryCode_]]"
+ on-change="onCountryChange_">
+ <option value=""></option>
<template is="dom-repeat" items="[[countries_]]">
- <button class="dropdown-item" role="option"
- code="[[getCode_(item)]]" disabled="[[isDivision_(item)]]">
+ <option value="[[getCode_(item)]]"
+ disabled="[[isDivision_(item)]]">
[[getName_(item)]]
- </button>
+ </option>
</template>
- </paper-listbox>
- </paper-dropdown-menu-light>
+ </select>
+ <span class="select-underline"></span>
+ </span>
</div>
<div class="address-row">
<paper-input id="phoneInput" type="text" label="$i18n{addressPhone}"
« no previous file with comments | « no previous file | chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698