Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: tools/dom/templates/html/impl/impl_WheelEvent.darttemplate

Issue 23829002: Checkpoint in changes to match push (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: We were missing onReadyStateChange Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/src/CrossFrameTypes.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/templates/html/impl/impl_WheelEvent.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_WheelEvent.darttemplate b/tools/dom/templates/html/impl/impl_WheelEvent.darttemplate
index a11cb22c08c6ba6e657400fc397b471c6488553f..d74369541bdcb2242dbee4410ebf2f3d35eceb8c 100644
--- a/tools/dom/templates/html/impl/impl_WheelEvent.darttemplate
+++ b/tools/dom/templates/html/impl/impl_WheelEvent.darttemplate
@@ -65,8 +65,9 @@ $if DART2JS
metaKey, button, relatedTarget, axis);
} else {
$else
- // Dartium always needs these flipped because we're essentially always
- // polyfilling (see similar dart2js code as well)
+ // Dartium always needs these flipped because we're using the legacy
+ // _initWebKitWheelEvent instead of the more modern WheelEvent constructor
+ // which isn't yet properly exposed by the Dartium bindings.
deltaX = -deltaX;
deltaY = -deltaY;
$endif
@@ -74,8 +75,7 @@ $endif
event._initMouseEvent(type, canBubble, cancelable, view, detail,
screenX, screenY, clientX, clientY, ctrlKey, altKey, shiftKey,
metaKey, button, relatedTarget);
- event._initWebKitWheelEvent(deltaX,
- deltaY ~/ 120, // Chrome does an auto-convert to pixels.
+ event._initWebKitWheelEvent(deltaX, deltaY,
view, screenX, screenY, clientX, clientY, ctrlKey, altKey, shiftKey,
metaKey);
$if DART2JS
@@ -230,7 +230,7 @@ $else
* * [WheelEvent.deltaX](http://dev.w3.org/2006/webapi/DOM-Level-3-Events/html/DOM3-Events.html#events-WheelEvent-deltaX) from the W3C.
*/
@DomName('WheelEvent.deltaX')
- num get deltaX => -_wheelDeltaX;
+ num get deltaX => _deltaX;
/**
* The amount that is expected to scroll vertically, in units determined by
@@ -241,6 +241,6 @@ $else
* * [WheelEvent.deltaY](http://dev.w3.org/2006/webapi/DOM-Level-3-Events/html/DOM3-Events.html#events-WheelEvent-deltaY) from the W3C.
*/
@DomName('WheelEvent.deltaY')
- num get deltaY => -_wheelDeltaY;
+ num get deltaY => _deltaY;
$endif
}
« no previous file with comments | « tools/dom/src/CrossFrameTypes.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698