Implement OffscreenCanvas.commit() on Unaccelerated 2D on worker

Implement OffscreenCanvas.commit() on Unaccelerated 2D on worker

This CL allows access to shared_bitmap_manager on worker thread,
and thereby enabling OffscreenCanvas's unaccelerated 2d commit()
on worker.

Safety of this approach:
1. The shared_bitmap_manager is guaranteed to be created when
RenderThreadImpl's parent class ChildThreadImpl is constructed
(see ChildThreadImpl::Init()). Also,
Worker threads are created when RenderThreadImpl is alive.
Thus, on worker thread, when calling AllocateSharedBitmap(),
the shared_bitmap_manager_ is always an alive pointer.
2. When RenderThreadImpl is destroyed, its unique pointer of
RendererBlinkPlatformImpl will be destroyed, which will set the
raw pointer of shared_bitmap_manager_ to be nullptr.
Next, its parent class ChildThreadImpl will be destroyed, and
thus tearing down its unique pointer of ChildSharedBitmapManager.
Thus, the shared_bitmap_manager_ raw pointer in
RendererBlinkPlatformImpl won't be left as a dangling pointer.

BUG=563858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/dbed4e430539a6853313b6810ea6a81a397c8556
Cr-Commit-Position: refs/heads/master@{#422460}

[xlai (Olivia), 2016-09-30 16:43:15]

The CQ bit was checked by xlai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 16:43:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xlai (Olivia), 2016-09-30 17:46:15]

Description was changed from

==========
[WIP] Implement OffscreenCanvas.commit() on Unaccelerated 2D on worker


BUG=563858
==========

to

==========
[WIP] Implement OffscreenCanvas.commit() on Unaccelerated 2D on worker


BUG=563858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[xlai (Olivia), 2016-09-30 18:01:50]

Description was changed from

==========
[WIP] Implement OffscreenCanvas.commit() on Unaccelerated 2D on worker


BUG=563858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Implement OffscreenCanvas.commit() on Unaccelerated 2D on worker

This CL allows access to shared_bitmap_manager on worker thread, 
and thereby enabling OffscreenCanvas's unaccelerated 2d commit()
on worker.

Safety of this approach:
The shared_bitmap_manager is guaranteed to be created when
RenderThreadImpl's parent class ChildThreadImpl is constructed
(see ChildThreadImpl::Init()). Also,
Worker threads are created when RenderThreadImpl is alive. 
Thus, on worker thread, when calling AllocateSharedBitmap(), 
the shared_bitmap_manager_ is always an alive pointer.


BUG=563858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[xlai (Olivia), 2016-09-30 18:59:20]

Description was changed from

==========
Implement OffscreenCanvas.commit() on Unaccelerated 2D on worker

This CL allows access to shared_bitmap_manager on worker thread, 
and thereby enabling OffscreenCanvas's unaccelerated 2d commit()
on worker.

Safety of this approach:
The shared_bitmap_manager is guaranteed to be created when
RenderThreadImpl's parent class ChildThreadImpl is constructed
(see ChildThreadImpl::Init()). Also,
Worker threads are created when RenderThreadImpl is alive. 
Thus, on worker thread, when calling AllocateSharedBitmap(), 
the shared_bitmap_manager_ is always an alive pointer.


BUG=563858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Implement OffscreenCanvas.commit() on Unaccelerated 2D on worker

This CL allows access to shared_bitmap_manager on worker thread, 
and thereby enabling OffscreenCanvas's unaccelerated 2d commit()
on worker.

Safety of this approach:
1. The shared_bitmap_manager is guaranteed to be created when
RenderThreadImpl's parent class ChildThreadImpl is constructed
(see ChildThreadImpl::Init()). Also,
Worker threads are created when RenderThreadImpl is alive. 
Thus, on worker thread, when calling AllocateSharedBitmap(), 
the shared_bitmap_manager_ is always an alive pointer.
2. When RenderThreadImpl is shutdown (and thus tearing down
its unique pointer of shared_bitmap_manager_), RendererBlinkPlatformImpl 
is also shutting down (See RenderThreadImpl::Shutdown()). Thus,
the shared_bitmap_manager_ pointer won't be left as a dangling
pointer.



BUG=563858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[xlai (Olivia), 2016-09-30 19:02:48]

xlai@chromium.org changed reviewers:
+ avi@chromium.org, junov@chromium.org, kbr@chromium.org

[xlai (Olivia), 2016-09-30 19:02:49]

PTAL. Thanks!

junov@: OffscreenCanvasFrameDispatcher
avi@: content/renderer/
kbr@: gpu pixel tests

[xlai (Olivia), 2016-09-30 19:08:10]

Patchset #3 (id:40001) has been deleted

[xlai (Olivia), 2016-09-30 19:19:54]

Description was changed from

==========
Implement OffscreenCanvas.commit() on Unaccelerated 2D on worker

This CL allows access to shared_bitmap_manager on worker thread, 
and thereby enabling OffscreenCanvas's unaccelerated 2d commit()
on worker.

Safety of this approach:
1. The shared_bitmap_manager is guaranteed to be created when
RenderThreadImpl's parent class ChildThreadImpl is constructed
(see ChildThreadImpl::Init()). Also,
Worker threads are created when RenderThreadImpl is alive. 
Thus, on worker thread, when calling AllocateSharedBitmap(), 
the shared_bitmap_manager_ is always an alive pointer.
2. When RenderThreadImpl is shutdown (and thus tearing down
its unique pointer of shared_bitmap_manager_), RendererBlinkPlatformImpl 
is also shutting down (See RenderThreadImpl::Shutdown()). Thus,
the shared_bitmap_manager_ pointer won't be left as a dangling
pointer.



BUG=563858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Implement OffscreenCanvas.commit() on Unaccelerated 2D on worker

This CL allows access to shared_bitmap_manager on worker thread, 
and thereby enabling OffscreenCanvas's unaccelerated 2d commit()
on worker.

Safety of this approach:
1. The shared_bitmap_manager is guaranteed to be created when
RenderThreadImpl's parent class ChildThreadImpl is constructed
(see ChildThreadImpl::Init()). Also,
Worker threads are created when RenderThreadImpl is alive. 
Thus, on worker thread, when calling AllocateSharedBitmap(), 
the shared_bitmap_manager_ is always an alive pointer.
2. When RenderThreadImpl is destroyed, its unique pointer of
blink_platform_impl_ will be destroyed, which will set the raw pointer
of shared_bitmap_manager_ to be nullptr. Next, its parent class
ChildThreadImpl will be destroyed, and thus tearing down its 
unique pointer of shared_bitmap_manager_. Thus,
the shared_bitmap_manager_ pointer in BlinkPlatformImpl won't be 
left as a dangling pointer.



BUG=563858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[xlai (Olivia), 2016-09-30 19:22:42]

Description was changed from

==========
Implement OffscreenCanvas.commit() on Unaccelerated 2D on worker

This CL allows access to shared_bitmap_manager on worker thread, 
and thereby enabling OffscreenCanvas's unaccelerated 2d commit()
on worker.

Safety of this approach:
1. The shared_bitmap_manager is guaranteed to be created when
RenderThreadImpl's parent class ChildThreadImpl is constructed
(see ChildThreadImpl::Init()). Also,
Worker threads are created when RenderThreadImpl is alive. 
Thus, on worker thread, when calling AllocateSharedBitmap(), 
the shared_bitmap_manager_ is always an alive pointer.
2. When RenderThreadImpl is destroyed, its unique pointer of
blink_platform_impl_ will be destroyed, which will set the raw pointer
of shared_bitmap_manager_ to be nullptr. Next, its parent class
ChildThreadImpl will be destroyed, and thus tearing down its 
unique pointer of shared_bitmap_manager_. Thus,
the shared_bitmap_manager_ pointer in BlinkPlatformImpl won't be 
left as a dangling pointer.



BUG=563858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Implement OffscreenCanvas.commit() on Unaccelerated 2D on worker

This CL allows access to shared_bitmap_manager on worker thread, 
and thereby enabling OffscreenCanvas's unaccelerated 2d commit()
on worker.

Safety of this approach:
1. The shared_bitmap_manager is guaranteed to be created when
RenderThreadImpl's parent class ChildThreadImpl is constructed
(see ChildThreadImpl::Init()). Also,
Worker threads are created when RenderThreadImpl is alive. 
Thus, on worker thread, when calling AllocateSharedBitmap(), 
the shared_bitmap_manager_ is always an alive pointer.
2. When RenderThreadImpl is destroyed, its unique pointer of
RendererBlinkPlatformImpl will be destroyed, which will set the
raw pointer of shared_bitmap_manager_ to be nullptr. 
Next, its parent class ChildThreadImpl will be destroyed, and
thus tearing down its unique pointer of ChildSharedBitmapManager.
Thus, the shared_bitmap_manager_ raw pointer in
RendererBlinkPlatformImpl won't be left as a dangling pointer.



BUG=563858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[Avi (use Gerrit), 2016-09-30 19:46:51]

The content changes seem pretty mechanical. LGTM stamp

[xlai (Olivia), 2016-09-30 20:51:21]

Patchset #4 (id:80001) has been deleted

[Ken Russell (switch to Gerrit), 2016-09-30 23:04:41]

Great! Nice work adding a test right away. One comment. LGTM

https://codereview.chromium.org/2382883005/diff/100001/content/test/gpu/gpu_t...
File content/test/gpu/gpu_tests/pixel_test_pages.py (right):

https://codereview.chromium.org/2382883005/diff/100001/content/test/gpu/gpu_t...
content/test/gpu/gpu_tests/pixel_test_pages.py:196:
'--disable-gpu-compositing']),
At this point you could declare something like

  unaccelerated_args = [
    '--disable-accelerated-2d-canvas',
    '--disable-gpu-compositing']

and use it for both the OffscreenCanvasUnaccelerated2D and
OffscreenCanvasUnaccelerated2DWorker tests:

  browser_args = browser_args + unaccelerated_args

[Justin Novosad, 2016-10-03 15:13:53]

lgtm

https://codereview.chromium.org/2382883005/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp
(right):

https://codereview.chromium.org/2382883005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp:64:
if (!image->isTextureBacked()) {
Nit: Remove the '!' and swap what is before/after the else

[xlai (Olivia), 2016-10-03 16:24:22]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2016-10-03 16:24:22]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
kbr@chromium.org, junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2382883005/#ps120001
(title: "rebase   Nits")

[commit-bot: I haz the power, 2016-10-03 16:24:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 18:07:45]

Description was changed from

==========
Implement OffscreenCanvas.commit() on Unaccelerated 2D on worker

This CL allows access to shared_bitmap_manager on worker thread, 
and thereby enabling OffscreenCanvas's unaccelerated 2d commit()
on worker.

Safety of this approach:
1. The shared_bitmap_manager is guaranteed to be created when
RenderThreadImpl's parent class ChildThreadImpl is constructed
(see ChildThreadImpl::Init()). Also,
Worker threads are created when RenderThreadImpl is alive. 
Thus, on worker thread, when calling AllocateSharedBitmap(), 
the shared_bitmap_manager_ is always an alive pointer.
2. When RenderThreadImpl is destroyed, its unique pointer of
RendererBlinkPlatformImpl will be destroyed, which will set the
raw pointer of shared_bitmap_manager_ to be nullptr. 
Next, its parent class ChildThreadImpl will be destroyed, and
thus tearing down its unique pointer of ChildSharedBitmapManager.
Thus, the shared_bitmap_manager_ raw pointer in
RendererBlinkPlatformImpl won't be left as a dangling pointer.



BUG=563858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Implement OffscreenCanvas.commit() on Unaccelerated 2D on worker

This CL allows access to shared_bitmap_manager on worker thread, 
and thereby enabling OffscreenCanvas's unaccelerated 2d commit()
on worker.

Safety of this approach:
1. The shared_bitmap_manager is guaranteed to be created when
RenderThreadImpl's parent class ChildThreadImpl is constructed
(see ChildThreadImpl::Init()). Also,
Worker threads are created when RenderThreadImpl is alive. 
Thus, on worker thread, when calling AllocateSharedBitmap(), 
the shared_bitmap_manager_ is always an alive pointer.
2. When RenderThreadImpl is destroyed, its unique pointer of
RendererBlinkPlatformImpl will be destroyed, which will set the
raw pointer of shared_bitmap_manager_ to be nullptr. 
Next, its parent class ChildThreadImpl will be destroyed, and
thus tearing down its unique pointer of ChildSharedBitmapManager.
Thus, the shared_bitmap_manager_ raw pointer in
RendererBlinkPlatformImpl won't be left as a dangling pointer.



BUG=563858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-10-03 18:07:46]

Committed patchset #5 (id:120001)

[commit-bot: I haz the power, 2016-10-03 18:10:25]

Description was changed from

==========
Implement OffscreenCanvas.commit() on Unaccelerated 2D on worker

This CL allows access to shared_bitmap_manager on worker thread, 
and thereby enabling OffscreenCanvas's unaccelerated 2d commit()
on worker.

Safety of this approach:
1. The shared_bitmap_manager is guaranteed to be created when
RenderThreadImpl's parent class ChildThreadImpl is constructed
(see ChildThreadImpl::Init()). Also,
Worker threads are created when RenderThreadImpl is alive. 
Thus, on worker thread, when calling AllocateSharedBitmap(), 
the shared_bitmap_manager_ is always an alive pointer.
2. When RenderThreadImpl is destroyed, its unique pointer of
RendererBlinkPlatformImpl will be destroyed, which will set the
raw pointer of shared_bitmap_manager_ to be nullptr. 
Next, its parent class ChildThreadImpl will be destroyed, and
thus tearing down its unique pointer of ChildSharedBitmapManager.
Thus, the shared_bitmap_manager_ raw pointer in
RendererBlinkPlatformImpl won't be left as a dangling pointer.



BUG=563858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

to

==========
Implement OffscreenCanvas.commit() on Unaccelerated 2D on worker

This CL allows access to shared_bitmap_manager on worker thread,
and thereby enabling OffscreenCanvas's unaccelerated 2d commit()
on worker.

Safety of this approach:
1. The shared_bitmap_manager is guaranteed to be created when
RenderThreadImpl's parent class ChildThreadImpl is constructed
(see ChildThreadImpl::Init()). Also,
Worker threads are created when RenderThreadImpl is alive.
Thus, on worker thread, when calling AllocateSharedBitmap(),
the shared_bitmap_manager_ is always an alive pointer.
2. When RenderThreadImpl is destroyed, its unique pointer of
RendererBlinkPlatformImpl will be destroyed, which will set the
raw pointer of shared_bitmap_manager_ to be nullptr.
Next, its parent class ChildThreadImpl will be destroyed, and
thus tearing down its unique pointer of ChildSharedBitmapManager.
Thus, the shared_bitmap_manager_ raw pointer in
RendererBlinkPlatformImpl won't be left as a dangling pointer.

BUG=563858
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Committed: https://crrev.com/dbed4e430539a6853313b6810ea6a81a397c8556
Cr-Commit-Position: refs/heads/master@{#422460}
==========

[commit-bot: I haz the power, 2016-10-03 18:10:27]

Patchset 5 (id:??) landed as
https://crrev.com/dbed4e430539a6853313b6810ea6a81a397c8556
Cr-Commit-Position: refs/heads/master@{#422460}