Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: content/browser/renderer_host/compositor_impl_android.cc

Issue 2382873002: Replace usage of SurfaceId's client_id with FrameSinkId (Closed)
Patch Set: Fixed windows + android + mac issues Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/compositor_impl_android.cc
diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc
index 9a1a596f19323877344d72f0fe10b561a7899df6..eff1a08102fe1be7e20345728c43258819413fd4 100644
--- a/content/browser/renderer_host/compositor_impl_android.cc
+++ b/content/browser/renderer_host/compositor_impl_android.cc
@@ -330,7 +330,7 @@ class VulkanOutputSurface : public cc::OutputSurface {
return true;
}
- bool BindToClient(cc::OutputSurfaceClient* client) override {
+ bool BindToClient(cc::OutputFrameSink* client) override {
boliu 2016/09/30 21:06:06 does this compile? this is still an OutputSurface,
Fady Samuel 2016/09/30 21:49:30 Done.
danakj 2016/09/30 23:10:43 We don't actually build with ENABLE_VULKAN anywher
if (!OutputSurface::BindToClient(client))
return false;
return true;
@@ -398,9 +398,8 @@ bool CompositorImpl::IsInitialized() {
CompositorImpl::CompositorImpl(CompositorClient* client,
gfx::NativeWindow root_window)
- : surface_id_allocator_(
- new cc::SurfaceIdAllocator(ui::ContextProviderFactory::GetInstance()
- ->AllocateSurfaceClientId())),
+ : surface_id_allocator_(new cc::SurfaceIdAllocator(
+ ui::ContextProviderFactory::GetInstance()->AllocateFrameSinkId())),
resource_manager_(root_window),
has_transparent_background_(false),
device_scale_factor_(1),
@@ -416,7 +415,7 @@ CompositorImpl::CompositorImpl(CompositorClient* client,
weak_factory_(this) {
ui::ContextProviderFactory::GetInstance()
->GetSurfaceManager()
- ->RegisterSurfaceClientId(surface_id_allocator_->client_id());
+ ->RegisterFrameSinkId(surface_id_allocator_->frame_sink_id());
DCHECK(client);
DCHECK(root_window);
DCHECK(root_window->GetLayer() == nullptr);
@@ -436,7 +435,7 @@ CompositorImpl::~CompositorImpl() {
SetSurface(NULL);
ui::ContextProviderFactory::GetInstance()
->GetSurfaceManager()
- ->InvalidateSurfaceClientId(surface_id_allocator_->client_id());
+ ->InvalidateFrameSinkId(surface_id_allocator_->frame_sink_id());
}
ui::UIResourceProvider& CompositorImpl::GetUIResourceProvider() {
@@ -521,7 +520,7 @@ void CompositorImpl::CreateLayerTreeHost() {
host_ = cc::LayerTreeHostInProcess::CreateSingleThreaded(this, &params);
DCHECK(!host_->IsVisible());
host_->GetLayerTree()->SetRootLayer(root_window_->GetLayer());
- host_->SetSurfaceClientId(surface_id_allocator_->client_id());
+ host_->SetFrameSinkId(surface_id_allocator_->frame_sink_id());
host_->GetLayerTree()->SetViewportSize(size_);
host_->GetLayerTree()->set_has_transparent_background(
has_transparent_background_);

Powered by Google App Engine
This is Rietveld 408576698