Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issue 23828008: Add an even more convenient way to declare tests, with example. (Closed)

Created:
7 years, 3 months ago by mtklein
Modified:
7 years, 3 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add an even more convenient way to declare tests, with example. BUG= R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=11405

Patch Set 1 #

Patch Set 2 : DEF_TEST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M tests/AAClipTest.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M tests/TestClassDef.h View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtklein
Just a little convenience thing I keep wanting.
7 years, 3 months ago (2013-09-19 16:19:07 UTC) #1
reed1
in other apps, we use DEF_BENCH DEF_GM can we use DEF_TEST here?
7 years, 3 months ago (2013-09-19 18:14:57 UTC) #2
mtklein
On 2013/09/19 18:14:57, reed1 wrote: > in other apps, we use > > DEF_BENCH > ...
7 years, 3 months ago (2013-09-19 18:18:09 UTC) #3
reed1
lgtm
7 years, 3 months ago (2013-09-19 19:04:32 UTC) #4
mtklein
7 years, 3 months ago (2013-09-19 20:56:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r11405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698