UseSkOnce to squelch command buffer spam

Use SkOnce to squelch command buffer spam

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2382793002

Committed: https://skia.googlesource.com/skia/+/69e7eba6aef583eb0561019539b164d8e0eed025

[Brian Osman, 2016-09-29 15:12:04]

Description was changed from

==========
Add SkDebugf_Once to squelch command buffer spam

Obviously the same pattern can be applied to things like asserts (if you
only care about the first instance), etc... For now, this is the only
instance I know about that warrants this treatment.

BUG=skia:
==========

to

==========
Add SkDebugf_Once to squelch command buffer spam

Obviously the same pattern can be applied to things like asserts (if you
only care about the first instance), etc... For now, this is the only
instance I know about that warrants this treatment.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2382793002
==========

[Brian Osman, 2016-09-29 15:13:14]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, egdaniel@google.com, mtklein@google.com

[mtklein, 2016-09-29 15:14:58]

Try SkOnce?

[Brian Osman, 2016-09-29 15:33:56]

On 2016/09/29 15:14:58, mtklein wrote:
> Try SkOnce?

Better? Now my choices were to add another header (seemed clumsy for clients),
put it in SkOnce.h (where it doesn't really belong), or rely on the delayed
macro expansion - but that feels extra dirty?

[mtklein_C, 2016-09-29 15:40:43]

mtklein@chromium.org changed reviewers:
+ mtklein@chromium.org

[mtklein_C, 2016-09-29 15:40:43]

This LGTM.

Have we considered going one step further to SkDebugf_Never(...) ?

[mtklein_C, 2016-09-29 15:42:10]

I think this might also be clearer without the new macro, inlined into
GLTestContext_command_buffer.cpp directly.

[Brian Osman, 2016-09-29 17:29:13]

Description was changed from

==========
Add SkDebugf_Once to squelch command buffer spam

Obviously the same pattern can be applied to things like asserts (if you
only care about the first instance), etc... For now, this is the only
instance I know about that warrants this treatment.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2382793002
==========

to

==========
Use SkOnce to squelch command buffer spam

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2382793002
==========

[Brian Osman, 2016-09-29 17:29:24]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-09-29 17:29:24]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@chromium.org
Link to the patchset: https://codereview.chromium.org/2382793002/#ps40001
(title: "Just use SkOnce inlined. This is the only interesting use case right
now.")

[commit-bot: I haz the power, 2016-09-29 17:29:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-09-29 17:37:41]

On 2016/09/29 at 17:29:33, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

lgtm!

[commit-bot: I haz the power, 2016-09-29 17:49:48]

Description was changed from

==========
Use SkOnce to squelch command buffer spam

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2382793002
==========

to

==========
Use SkOnce to squelch command buffer spam

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2382793002

Committed:
https://skia.googlesource.com/skia/+/69e7eba6aef583eb0561019539b164d8e0eed025
==========

[commit-bot: I haz the power, 2016-09-29 17:49:49]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/69e7eba6aef583eb0561019539b164d8e0eed025