blimp/client/core/feedback/BUILD.gn - Issue 2382733007: Add BlimpDocument, pull out functions in BlimpCompositor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/feedback/BUILD.gn

Issue 2382733007: Add BlimpDocument, pull out functions in BlimpCompositor. (Closed)

Patch Set: Fix linux client. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/feedback/BUILD.gn

diff --git a/blimp/client/core/feedback/BUILD.gn b/blimp/client/core/feedback/BUILD.gn

index e154c3cbbdd1a2a8914d6d90755198f08193cbed..1c8209363b06a6c3a122e37323bdd80d6b1b4d45 100644

--- a/blimp/client/core/feedback/BUILD.gn

+++ b/blimp/client/core/feedback/BUILD.gn

@@ -18,6 +18,7 @@ source_set("feedback") {

deps = [

"//base",

"//blimp/client/core/contents",

+ "//skia",

Khushal 2016/10/03 20:04:59 Is skia needed here?

xingliu 2016/10/04 18:33:49 Removed, I think I got gn check failed before reba

]

if (is_android) {