Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2382733002: Introduce markChildForPaginationRelayoutIfNeeded(). (Closed)

Created:
4 years, 2 months ago by mstensho (USE GERRIT)
Modified:
4 years, 2 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce markChildForPaginationRelayoutIfNeeded(). No behavioral changes intended. This replaces markForPaginationRelayoutIfNeeded(). Since the method was always called when it was the container that was being laid out, this is more "correct", and in the same spirit as e.g. updateBlockChildDirtyBitsBeforeLayout(), adjustBlockChildForPagination(), and so on. This is a preparatory patch to allow for calling offsetFromLogicalTopOfFirstPage(), which uses LayoutState more heavily. When using LayoutState, you generally need to be laying out the very same object as the one LayoutState points to. BUG=487026 Committed: https://crrev.com/74ff11de78f94ac88173da124c23ca6b6b333642 Cr-Commit-Position: refs/heads/master@{#421815}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
The actual fix for bug 487026 is further down the road, but if you want ...
4 years, 2 months ago (2016-09-29 13:06:43 UTC) #4
eae
LGTM
4 years, 2 months ago (2016-09-29 14:30:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382733002/1
4 years, 2 months ago (2016-09-29 14:31:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 14:38:41 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 14:40:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74ff11de78f94ac88173da124c23ca6b6b333642
Cr-Commit-Position: refs/heads/master@{#421815}

Powered by Google App Engine
This is Rietveld 408576698