Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 238273012: Staged removal of SkPicture-derived classes (Closed)

Created:
6 years, 8 months ago by robertphillips
Modified:
6 years, 8 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Staged removal of SkPicture-derived classes This CL removes the SkPicture-derived classes (with a flag to keeps clients working). In the process it also lightens the recording factory function so it is no longer ref counted). The only interesting bits are in SkPicture* and Sk*Picture.* Committed: http://code.google.com/p/skia/source/detail?r=14251

Patch Set 1 #

Patch Set 2 : fix debug build #

Patch Set 3 : Mac 10.7 cannot face a harsh world where files don't end in a newline #

Patch Set 4 : It is a cruel, cruel, newline-less world out there #

Patch Set 5 : fix virtual dtor bug #

Patch Set 6 : Get compiling in Chrome #

Patch Set 7 : have SkPicture only friend SkPictureRecorder once #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -186 lines) Patch
M bench/PicturePlaybackBench.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M bench/PictureRecordBench.cpp View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M bench/benchmain.cpp View 1 2 3 4 5 2 chunks +8 lines, -4 lines 0 comments Download
M debugger/SkDebugger.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M dm/DMReplayTask.cpp View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M dm/DMTileGridTask.cpp View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
M dm/DMUtil.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M dm/DMUtil.cpp View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M gm/distantclip.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M gm/gmmain.cpp View 1 2 3 4 5 1 chunk +7 lines, -7 lines 0 comments Download
M gm/optimizations.cpp View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M gm/pathopsskpclip.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M gm/pictureimagefilter.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M gm/pictureshader.cpp View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M gyp/common_conditions.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkPicture.h View 1 2 3 4 5 6 9 chunks +47 lines, -5 lines 0 comments Download
M include/core/SkRTreePicture.h View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
M include/core/SkTileGridPicture.h View 1 2 3 4 5 2 chunks +29 lines, -11 lines 0 comments Download
M samplecode/SampleAll.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SamplePictFile.cpp View 1 2 3 4 5 3 chunks +9 lines, -9 lines 0 comments Download
M samplecode/SamplePicture.cpp View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M samplecode/SampleTiling.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPicture.cpp View 1 2 3 4 5 3 chunks +41 lines, -0 lines 0 comments Download
M src/core/SkQuadTreePicture.h View 1 2 3 4 5 2 chunks +12 lines, -0 lines 0 comments Download
M src/core/SkQuadTreePicture.cpp View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M src/core/SkRTreePicture.cpp View 1 2 3 4 5 2 chunks +17 lines, -0 lines 0 comments Download
M src/core/SkTileGrid.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkTileGrid.cpp View 1 2 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download
M src/core/SkTileGridPicture.cpp View 1 2 3 4 5 2 chunks +20 lines, -1 line 0 comments Download
M tests/CanvasTest.cpp View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M tests/PictureTest.cpp View 1 2 3 4 5 24 chunks +38 lines, -38 lines 0 comments Download
M tests/SerializationTest.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M tests/TileGridTest.cpp View 1 2 3 4 5 5 chunks +9 lines, -9 lines 0 comments Download
M tools/PictureRenderer.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M tools/PictureRenderer.cpp View 1 2 3 4 5 4 chunks +13 lines, -10 lines 0 comments Download
M tools/PictureRenderingFlags.cpp View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M tools/bench_record.cpp View 1 2 3 4 5 4 chunks +18 lines, -39 lines 0 comments Download
M tools/filtermain.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M tools/render_pictures_main.cpp View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M tools/skpmaker.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
6 years, 8 months ago (2014-04-17 17:25:46 UTC) #1
reed1
lgtm
6 years, 8 months ago (2014-04-17 17:30:14 UTC) #2
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 8 months ago (2014-04-17 23:34:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/238273012/120001
6 years, 8 months ago (2014-04-17 23:34:32 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-17 23:35:21 UTC) #5
Message was sent while issue was closed. 
Change committed as 14251

Powered by Google App Engine
This is Rietveld 408576698