rietveld.py - Issue 238273011: Fixed reauthentication issue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: rietveld.py

Issue 238273011: Fixed reauthentication issue (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: rietveld.py

diff --git a/rietveld.py b/rietveld.py

index e296181ade2130e366cd904bf1a35ba483fe9b06..0af88006e8a8871e55258ca203ae184b1e77c6bc 100644

--- a/rietveld.py

+++ b/rietveld.py

@@ -30,6 +30,8 @@ from third_party import upload

import third_party.oauth2client.client as oa2client

from third_party import httplib2

+# appengine replies with 302 when authentication fails (sigh)

Ryan Tseng 2014/04/17 17:10:40 nit: s/appengine/Appengine/g Also add period.

pgervais 2014/04/17 17:28:00 Done.

+oa2client.REFRESH_STATUS_CODES = [302, 401]

Ryan Tseng 2014/04/17 17:10:40 Use oa2client.REFRESH_STATUS_CODES.append(302) ins

pgervais 2014/04/17 17:28:00 Done.

M-A Ruel 2014/04/17 19:12:47 You forgot to upload a new version.

upload.LOGGER.setLevel(logging.WARNING) # pylint: disable=E1103

« no previous file with comments | « no previous file | no next file » | no next file with comments »