Issue 238273007: Avoid duplication of calling getTransformedClipBounds in stroke APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 238273007: Avoid duplication of calling getTransformedClipBounds in stroke APIs. (Closed)

Created:
6 years, 8 months ago by zino

Modified:
6 years, 8 months ago

Reviewers:
Justin Novosad

CC:
blink-reviews, aandrey+blink_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Avoid duplication of calling getTransformedClipBounds in stroke APIs. We can avoid duplication of calling getTransformedClipBounds by using computeDirtyRect which takes three arguments. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171733

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/html/canvas/CanvasRenderingContext2D.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

zino

It is my mistake. (https://codereview.chromium.org/227213002/) We don't need re-calculating clipBounds. Thank you :)

6 years, 8 months ago (2014-04-15 09:57:26 UTC) #1

Justin Novosad

On 2014/04/15 09:57:26, zino wrote: > It is my mistake. > (https://codereview.chromium.org/227213002/) > We don't ...

6 years, 8 months ago (2014-04-15 14:22:00 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/238273007/1

6 years, 8 months ago (2014-04-16 01:27:53 UTC) #4

Message was sent while issue was closed.

Change committed as 171733

Expand Messages | Collapse Messages