Issue 238273005: Handlify BasicJsonStringifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 238273005: Handlify BasicJsonStringifier. (Closed)

Created:
6 years, 8 months ago by Yang

Modified:
6 years, 8 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify BasicJsonStringifier. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20768

Patch Set 2 : changed the way we handle exceptions #

Total comments: 1

Patch Set 3 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -35 lines)			Patch
	M	src/json-stringifier.h	View	1 2	9 chunks	+36 lines, -33 lines	0 comments	Download
	M	src/runtime.cc	View		2 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with a nit: https://codereview.chromium.org/238273005/diff/1/src/json-stringifier.h File src/json-stringifier.h (right): https://codereview.chromium.org/238273005/diff/1/src/json-stringifier.h#newcode295 src/json-stringifier.h:295: default: "case EXCEPTION:" instead of ...

6 years, 8 months ago (2014-04-15 11:50:51 UTC) #2

Yang

Please take another look. I unified the different types of exceptions.

6 years, 8 months ago (2014-04-15 12:08:51 UTC) #3

Igor Sheludko

lgtm once note is addressed: https://codereview.chromium.org/238273005/diff/20001/src/json-stringifier.h File src/json-stringifier.h (right): https://codereview.chromium.org/238273005/diff/20001/src/json-stringifier.h#newcode400 src/json-stringifier.h:400: if (elements->get(i) == *object) ...

6 years, 8 months ago (2014-04-15 12:46:27 UTC) #4