media/formats/webm/webm_cluster_parser.cc - Issue 238273002: Adds WebMClusterParserTest coverage for duration default/estimation/fallback logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/webm/webm_cluster_parser.cc

Issue 238273002: Adds WebMClusterParserTest coverage for duration default/estimation/fallback logic (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cast to int to compare enum values in COMPILE_ASSERTs Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/formats/webm/webm_cluster_parser.cc

diff --git a/media/formats/webm/webm_cluster_parser.cc b/media/formats/webm/webm_cluster_parser.cc

index 5a3adc363d30ba7309a0e82cd49d00c6e7d2a4cb..e206107c8b4f6d75b9b0205e401b3e38a8b8be48 100644

--- a/media/formats/webm/webm_cluster_parser.cc

+++ b/media/formats/webm/webm_cluster_parser.cc

@@ -15,13 +15,6 @@

#include "media/formats/webm/webm_crypto_helpers.h"

#include "media/formats/webm/webm_webvtt_parser.h"

-// Arbitrarily-chosen numbers to estimate the duration of a buffer if none is

-// set and there is not enough information to get a better estimate.

-// TODO(wolenetz/acolwell): Parse audio codebook to determine missing audio

-// frame durations. See http://crbug.com/351166.

-static int kDefaultAudioBufferDurationInMs = 23; // Common 1k samples @44.1kHz

-static int kDefaultVideoBufferDurationInMs = 42; // Low 24fps to reduce stalls

namespace media {

WebMClusterParser::WebMClusterParser(

« no previous file with comments | « media/formats/webm/webm_cluster_parser.h ('k') | media/formats/webm/webm_cluster_parser_unittest.cc » ('j') | no next file with comments »