Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2382723007: Use FileDescriptorWatcher in ClipboardX11. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
Jamie
CC:
chromium-reviews, dcheng, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use FileDescriptorWatcher in ClipboardX11. This allows ClipboardX11 to be used from any thread that instantiates a FileDescriptorWatcher (not just threads that run a MessageLoopForIO). This will facilitate the migration of BrowserThreads to base/task_scheduler. BUG=645114 Committed: https://crrev.com/cd80c412bd3fce4aca1f9ea6a30030bc1b4a862e Cr-Commit-Position: refs/heads/master@{#422448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -20 lines) Patch
M remoting/host/clipboard_x11.cc View 7 chunks +7 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-03 15:02:21 UTC) #6
Jamie
lgtm
4 years, 2 months ago (2016-10-03 17:08:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382723007/1
4 years, 2 months ago (2016-10-03 17:09:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 17:23:02 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 17:24:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd80c412bd3fce4aca1f9ea6a30030bc1b4a862e
Cr-Commit-Position: refs/heads/master@{#422448}

Powered by Google App Engine
This is Rietveld 408576698