Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2382723006: Revert of Letting Flash join MediaSession (stack implementaion) (Closed)

Created:
4 years, 2 months ago by wjmaclean
Modified:
4 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@media_session_type
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Letting Flash join MediaSession (stack implementaion) (patchset #12 id:260001 of https://codereview.chromium.org/2274873003/ ) Reason for revert: This appears to be causing failures of: AudioFocusManagerTest.PepperRequestsGainFocus AudioFocusManagerTest.AbandoningGainFocusRevokesTopMostPepperSession AudioFocusManagerTest.GainDucksPepper on Linux ChromiumOS Tests (1) Cast Linux Original issue's description: > Letting Flash join MediaSession (stack implementaion) > > This CL lets Flash join and be managed by MediaSession. > Flash will take "Gain" audio focus, and sessions with Flash will duck instead of being suspended. > > Test flags: > --enable-default-media-session > --ppapi-flash-path=/opt/google/chrome/PepperFlash/libpepflashplayer.so > --enable-features=flash-join-media-session > > Test URL (can open multiple tabs and try): > http://xxyzzzq.github.io/sandbox/media-session/flash-test.html > > BUG=619084 > > Committed: https://crrev.com/bc67624f3ea12ffabfb129c269c7bd82c9a1127d > Cr-Commit-Position: refs/heads/master@{#422087} TBR=jochen@chromium.org,avayvod@chromium.org,mlamouri@chromium.org,zqzhang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619084 Committed: https://crrev.com/50cc6c67785970247fe6af026b82c199a37c631e Cr-Commit-Position: refs/heads/master@{#422098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -483 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/media/session/audio_focus_manager.h View 3 chunks +52 lines, -5 lines 0 comments Download
M content/browser/media/session/audio_focus_manager.cc View 2 chunks +82 lines, -60 lines 0 comments Download
M content/browser/media/session/audio_focus_manager_unittest.cc View 14 chunks +136 lines, -225 lines 0 comments Download
M content/browser/media/session/media_session.h View 5 chunks +11 lines, -26 lines 0 comments Download
M content/browser/media/session/media_session.cc View 14 chunks +15 lines, -65 lines 0 comments Download
M content/browser/media/session/media_session_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D docs/audio_focus.md View 1 chunk +0 lines, -98 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
wjmaclean
Created Revert of Letting Flash join MediaSession (stack implementaion)
4 years, 2 months ago (2016-09-30 13:28:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382723006/1
4 years, 2 months ago (2016-09-30 13:29:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 13:30:05 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 13:31:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50cc6c67785970247fe6af026b82c199a37c631e
Cr-Commit-Position: refs/heads/master@{#422098}

Powered by Google App Engine
This is Rietveld 408576698