Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2382663002: Change CSSCustomPropertyDeclaration::id() to isInherit() and isInitial() (Closed)

Created:
4 years, 2 months ago by Timothy Loh
Modified:
4 years, 2 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change CSSCustomPropertyDeclaration::id() to isInherit() and isInitial() This patch changes CSSCustomPropertyDeclaration so that we can query whether the declaration inherits or is the initial value. This is a little nicer since we don't have to expose the internal value for denoting variable references, CSSValueInternalVariableValue. Committed: https://crrev.com/b2c39794fc5139948290de19c3f38eb006cb6b44 Cr-Commit-Position: refs/heads/master@{#421785}

Patch Set 1 #

Patch Set 2 : moo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp View 1 3 chunks +9 lines, -10 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
Timothy Loh
4 years, 2 months ago (2016-09-29 08:09:19 UTC) #6
meade_UTC10
lgtm
4 years, 2 months ago (2016-09-29 08:14:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382663002/20001
4 years, 2 months ago (2016-09-29 08:18:24 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-29 09:21:06 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 09:22:56 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b2c39794fc5139948290de19c3f38eb006cb6b44
Cr-Commit-Position: refs/heads/master@{#421785}

Powered by Google App Engine
This is Rietveld 408576698