Issue 238263008: MediaQueryTokenizer does not parse correctly negative exponents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 238263008: MediaQueryTokenizer does not parse correctly negative exponents (Closed)

Created:
6 years, 8 months ago by Inactive

Modified:
6 years, 8 months ago

Reviewers:
kenneth.r.christiansen, eseidel

CC:
blink-reviews, kenneth.christiansen, Yoav Weiss, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, Mads Ager (chromium)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

MediaQueryTokenizer does not parse correctly negative exponents MediaQueryTokenizer does not parse correctly negative exponents. The sign parameter for getExponent() was passed by value instead of reference. Therefore, setting the sign to -1 in the function had no impact on the caller. TEST=MediaQueryTokenizerTest Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171836

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	Source/core/css/parser/MediaQueryTokenizer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/css/parser/MediaQueryTokenizerTest.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/238263008/1

6 years, 8 months ago (2014-04-17 02:44:08 UTC) #3

Message was sent while issue was closed.

Change committed as 171836

Expand Messages | Collapse Messages