Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 238263003: Reland r20772 "Handlifying clients of StringTable, step 1." (Closed)

Created:
6 years, 8 months ago by Igor Sheludko
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Reland r20772 "Handlifying clients of StringTable, step 1." R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20813

Patch Set 1 #

Patch Set 2 : The fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -171 lines) Patch
M src/factory.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/heap.h View 2 chunks +4 lines, -9 lines 0 comments Download
M src/heap.cc View 5 chunks +86 lines, -136 lines 1 comment Download
M src/objects.h View 1 2 chunks +11 lines, -4 lines 0 comments Download
M src/objects.cc View 1 4 chunks +35 lines, -14 lines 0 comments Download
M src/runtime.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL, the fix is in patch set 2. https://codereview.chromium.org/238263003/diff/10001/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/238263003/diff/10001/src/heap.cc#newcode2928 src/heap.cc:2928: NameDictionary::New(isolate(), ...
6 years, 8 months ago (2014-04-16 13:45:17 UTC) #1
Yang
lgtm.
6 years, 8 months ago (2014-04-16 13:46:41 UTC) #2
Igor Sheludko
6 years, 8 months ago (2014-04-16 14:15:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20813 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698