Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2382623002: Add a test for MemoryMonitorAndroid::GetFreeMemoryUntilCriticalMB (Closed)

Created:
4 years, 2 months ago by bashi
Modified:
4 years, 2 months ago
Reviewers:
haraken, chrisha
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test for MemoryMonitorAndroid::GetFreeMemoryUntilCriticalMB BUG=617492 Committed: https://crrev.com/4939d8d105894827db5f63fd60ac4abf7bfd16d9 Cr-Commit-Position: refs/heads/master@{#421717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -20 lines) Patch
M content/browser/memory/memory_monitor_android.h View 2 chunks +14 lines, -1 line 0 comments Download
M content/browser/memory/memory_monitor_android.cc View 2 chunks +39 lines, -18 lines 0 comments Download
M content/browser/memory/memory_monitor_android_unittest.cc View 2 chunks +46 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
bashi
PTAL
4 years, 2 months ago (2016-09-29 01:20:08 UTC) #4
haraken
LGTM
4 years, 2 months ago (2016-09-29 01:29:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382623002/1
4 years, 2 months ago (2016-09-29 01:55:46 UTC) #9
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 2 months ago (2016-09-29 02:03:06 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 02:03:34 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4939d8d105894827db5f63fd60ac4abf7bfd16d9
Cr-Commit-Position: refs/heads/master@{#421717}

Powered by Google App Engine
This is Rietveld 408576698