Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2382603002: MD Settings: shrink overscroll on resize (Closed)

Created:
4 years, 2 months ago by michaelpg
Modified:
4 years, 2 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: shrink overscroll on resize Recalculate overscroll when shrinking the page, so we don't end up with a scrollbar for the empty space below us. BUG=none R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/9d6d419864045a027bccbadaaadb6b3bf34f467e Cr-Commit-Position: refs/heads/master@{#422684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings_main/settings_main.js View 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
michaelpg
small follow-up
4 years, 2 months ago (2016-09-29 02:07:56 UTC) #2
dschuyler
lgtm
4 years, 2 months ago (2016-09-29 22:40:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382603002/1
4 years, 2 months ago (2016-10-04 01:41:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 03:01:23 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 03:03:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d6d419864045a027bccbadaaadb6b3bf34f467e
Cr-Commit-Position: refs/heads/master@{#422684}

Powered by Google App Engine
This is Rietveld 408576698