Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: gpu/command_buffer/service/renderbuffer_manager.cc

Issue 2382573002: Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/renderbuffer_manager.cc
diff --git a/gpu/command_buffer/service/renderbuffer_manager.cc b/gpu/command_buffer/service/renderbuffer_manager.cc
index 203e74b849d661b1dab15eaa849b41e5069707a9..5c5270efda2d00a4934c1d6e340d3f3901d3ba13 100644
--- a/gpu/command_buffer/service/renderbuffer_manager.cc
+++ b/gpu/command_buffer/service/renderbuffer_manager.cc
@@ -250,24 +250,34 @@ GLenum RenderbufferManager::InternalRenderbufferFormatToImplFormat(
bool RenderbufferManager::OnMemoryDump(
const base::trace_event::MemoryDumpArgs& args,
base::trace_event::ProcessMemoryDump* pmd) {
- int client_id = memory_tracker_->ClientId();
- for (const auto& renderbuffer_entry : renderbuffers_) {
- const auto& client_renderbuffer_id = renderbuffer_entry.first;
- const auto& renderbuffer = renderbuffer_entry.second;
-
- std::string dump_name =
- base::StringPrintf("gpu/gl/renderbuffers/client_%d/renderbuffer_%d",
- client_id, client_renderbuffer_id);
- base::trace_event::MemoryAllocatorDump* dump =
- pmd->CreateAllocatorDump(dump_name);
- dump->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize,
- base::trace_event::MemoryAllocatorDump::kUnitsBytes,
- static_cast<uint64_t>(renderbuffer->EstimatedSize()));
-
- auto guid = gl::GetGLRenderbufferGUIDForTracing(
- memory_tracker_->ShareGroupTracingGUID(), client_renderbuffer_id);
- pmd->CreateSharedGlobalAllocatorDump(guid);
- pmd->AddOwnershipEdge(dump->guid(), guid);
+ using base::trace_event::MemoryAllocatorDump;
+ using base::trace_event::MemoryDumpLevelOfDetail;
+
+ if (args.level_of_detail == MemoryDumpLevelOfDetail::BACKGROUND) {
+ std::string dump_name = base::StringPrintf(
+ "gpu/gl/renderbuffers/client_%d/" PRIu64, memory_tracker_->ClientId());
+ MemoryAllocatorDump* dump = pmd->CreateAllocatorDump(dump_name);
+ dump->AddScalar(MemoryAllocatorDump::kNameSize,
+ MemoryAllocatorDump::kUnitsBytes, mem_represented());
+ } else {
+ int client_id = memory_tracker_->ClientId();
+ for (const auto& renderbuffer_entry : renderbuffers_) {
+ const auto& client_renderbuffer_id = renderbuffer_entry.first;
+ const auto& renderbuffer = renderbuffer_entry.second;
+
+ std::string dump_name =
+ base::StringPrintf("gpu/gl/renderbuffers/client_%d/renderbuffer_%d",
+ client_id, client_renderbuffer_id);
+ MemoryAllocatorDump* dump = pmd->CreateAllocatorDump(dump_name);
+ dump->AddScalar(MemoryAllocatorDump::kNameSize,
+ MemoryAllocatorDump::kUnitsBytes,
+ static_cast<uint64_t>(renderbuffer->EstimatedSize()));
+
+ auto guid = gl::GetGLRenderbufferGUIDForTracing(
+ memory_tracker_->ShareGroupTracingGUID(), client_renderbuffer_id);
+ pmd->CreateSharedGlobalAllocatorDump(guid);
+ pmd->AddOwnershipEdge(dump->guid(), guid);
+ }
}
return true;
}

Powered by Google App Engine
This is Rietveld 408576698