Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/c624f3d71afc0077b16ac8ca9d54296050b5d5d8
Committed: https://crrev.com/eff776983e13bd66ccb3637b39621f4bbe55d7ac
Cr-Original-Commit-Position: refs/heads/master@{#428769}
Cr-Commit-Position: refs/heads/master@{#429701}

[ericrk, 2016-09-28 21:40:12]

Description was changed from

==========
Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
==========

to

==========
Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ericrk, 2016-09-28 21:40:13]

Description was changed from

==========
Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ericrk, 2016-10-06 18:20:21]

ericrk@chromium.org changed reviewers:
+ ssid@chromium.org

[ericrk, 2016-10-06 18:20:21]

Here's an initial take at adding BACKGROUND dump mode to a bunch of GPU loggers.
Let me know if this seems reasonable.

There are a few more loggers I may want to add, but this should give a good
start.

[ssid, 2016-10-07 00:07:21]

lgtm, this could add lot of data to traces. I will try to enable as many as
possible for field trials. Thanks for doing this!

https://codereview.chromium.org/2382573002/diff/1/cc/tiles/gpu_image_decode_c...
File cc/tiles/gpu_image_decode_controller.cc (right):

https://codereview.chromium.org/2382573002/diff/1/cc/tiles/gpu_image_decode_c...
cc/tiles/gpu_image_decode_controller.cc:555:
TRACE_EVENT0("disabled-by-default-cc.debug",
Shouldn't this be using TRACE_DISABLED_BY_DEFAULT macro?

https://codereview.chromium.org/2382573002/diff/1/cc/tiles/gpu_image_decode_c...
cc/tiles/gpu_image_decode_controller.cc:564: MemoryAllocatorDump::kUnitsBytes,
bytes_used_);
if you do return true; here and remove else, it reduces indent.

https://codereview.chromium.org/2382573002/diff/1/gpu/command_buffer/client/m...
File gpu/command_buffer/client/mapped_memory.cc (right):

https://codereview.chromium.org/2382573002/diff/1/gpu/command_buffer/client/m...
gpu/command_buffer/client/mapped_memory.cc:180:
MemoryAllocatorDump::kUnitsBytes, allocated_memory_);
return here?

https://codereview.chromium.org/2382573002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/buffer_manager.cc (right):

https://codereview.chromium.org/2382573002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/buffer_manager.cc:655:
MemoryAllocatorDump::kUnitsBytes, mem_represented());
ditto

[ericrk, 2016-10-07 18:23:15]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 18:23:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 19:06:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 19:06:03]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[ericrk, 2016-10-07 20:25:31]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 20:25:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 20:29:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 20:29:14]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ericrk, 2016-10-07 21:02:08]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 21:02:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 22:10:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 22:10:25]

Dry run: This issue passed the CQ dry run.

[ericrk, 2016-10-13 23:58:12]

ericrk@chromium.org changed reviewers:
+ vmiura@chromium.org

[ericrk, 2016-10-13 23:58:14]

+vmiura for GPU/

https://codereview.chromium.org/2382573002/diff/1/cc/tiles/gpu_image_decode_c...
File cc/tiles/gpu_image_decode_controller.cc (right):

https://codereview.chromium.org/2382573002/diff/1/cc/tiles/gpu_image_decode_c...
cc/tiles/gpu_image_decode_controller.cc:555:
TRACE_EVENT0("disabled-by-default-cc.debug",
On 2016/10/07 00:07:21, ssid wrote:
> Shouldn't this be using TRACE_DISABLED_BY_DEFAULT macro?

sounds good - I put up a CL to update all of cc. crrev.com/2403523002

https://codereview.chromium.org/2382573002/diff/1/cc/tiles/gpu_image_decode_c...
cc/tiles/gpu_image_decode_controller.cc:564: MemoryAllocatorDump::kUnitsBytes,
bytes_used_);
On 2016/10/07 00:07:21, ssid wrote:
> if you do return true; here and remove else, it reduces indent.

Done.

https://codereview.chromium.org/2382573002/diff/1/gpu/command_buffer/client/m...
File gpu/command_buffer/client/mapped_memory.cc (right):

https://codereview.chromium.org/2382573002/diff/1/gpu/command_buffer/client/m...
gpu/command_buffer/client/mapped_memory.cc:180:
MemoryAllocatorDump::kUnitsBytes, allocated_memory_);
On 2016/10/07 00:07:21, ssid wrote:
> return here?

Done.

https://codereview.chromium.org/2382573002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/buffer_manager.cc (right):

https://codereview.chromium.org/2382573002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/buffer_manager.cc:655:
MemoryAllocatorDump::kUnitsBytes, mem_represented());
On 2016/10/07 00:07:21, ssid wrote:
> ditto

Done.

[ssid, 2016-10-14 13:39:55]

Description was changed from

==========
Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ericrk, 2016-10-25 17:59:59]

ericrk@chromium.org changed reviewers:
- vmiura@chromium.org

[ericrk, 2016-10-25 18:01:03]

ericrk@chromium.org changed reviewers:
+ vmiura@chromium.org, zmo@chromium.org

[ericrk, 2016-10-25 18:01:04]

+zmo for gpu changes

Thanks!

[Zhenyao Mo, 2016-10-25 18:17:12]

On 2016/10/25 18:01:04, ericrk wrote:
> +zmo for gpu changes
> 
> Thanks!

gpu/command_buffer lgtm

[ericrk, 2016-10-25 18:21:30]

ericrk@chromium.org changed reviewers:
+ vmpstr@chromium.org

[ericrk, 2016-10-25 18:21:30]

+vmpstr for cc

[ericrk, 2016-10-25 19:56:20]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 19:56:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 21:09:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 21:10:00]

Dry run: This issue passed the CQ dry run.

[ericrk, 2016-10-27 17:57:59]

friendly ping, vmpstr, can you take a look?

[vmpstr, 2016-10-28 22:30:57]

cc lgtm

[ericrk, 2016-10-28 22:31:07]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2016-10-28 22:31:08]

The patchset sent to the CQ was uploaded after l-g-t-m from ssid@chromium.org
Link to the patchset: https://codereview.chromium.org/2382573002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-28 22:31:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 22:49:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 22:49:03]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[ericrk, 2016-10-31 18:12:41]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2016-10-31 18:13:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 19:35:17]

Description was changed from

==========
Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-10-31 19:35:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-31 19:49:34]

Description was changed from

==========
Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/c624f3d71afc0077b16ac8ca9d54296050b5d5d8
Cr-Commit-Position: refs/heads/master@{#428769}
==========

[commit-bot: I haz the power, 2016-10-31 19:49:36]

Patchset 4 (id:??) landed as
https://crrev.com/c624f3d71afc0077b16ac8ca9d54296050b5d5d8
Cr-Commit-Position: refs/heads/master@{#428769}

[ericrk, 2016-11-01 19:46:00]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2467973004/ by ericrk@chromium.org.

The reason for reverting is: crbug.com/661194.

[ericrk, 2016-11-03 19:55:21]

Description was changed from

==========
Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/c624f3d71afc0077b16ac8ca9d54296050b5d5d8
Cr-Commit-Position: refs/heads/master@{#428769}
==========

to

==========
Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/c624f3d71afc0077b16ac8ca9d54296050b5d5d8
Cr-Commit-Position: refs/heads/master@{#428769}
==========

[ericrk, 2016-11-03 19:55:53]

Turns out this CL was mis-attributed for the bug referenced in the revert.
Re-landing.

[ericrk, 2016-11-03 19:56:00]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2016-11-03 19:56:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 21:37:57]

Description was changed from

==========
Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/c624f3d71afc0077b16ac8ca9d54296050b5d5d8
Cr-Commit-Position: refs/heads/master@{#428769}
==========

to

==========
Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/c624f3d71afc0077b16ac8ca9d54296050b5d5d8
Cr-Commit-Position: refs/heads/master@{#428769}
==========

[commit-bot: I haz the power, 2016-11-03 21:37:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-03 21:41:41]

Description was changed from

==========
Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/c624f3d71afc0077b16ac8ca9d54296050b5d5d8
Cr-Commit-Position: refs/heads/master@{#428769}
==========

to

==========
Add BACKGROUND dump mode to various GPU/CC MemoryDumpProviders

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/c624f3d71afc0077b16ac8ca9d54296050b5d5d8
Committed: https://crrev.com/eff776983e13bd66ccb3637b39621f4bbe55d7ac
Cr-Original-Commit-Position: refs/heads/master@{#428769}
Cr-Commit-Position: refs/heads/master@{#429701}
==========

[commit-bot: I haz the power, 2016-11-03 21:41:42]

Patchset 4 (id:??) landed as
https://crrev.com/eff776983e13bd66ccb3637b39621f4bbe55d7ac
Cr-Commit-Position: refs/heads/master@{#429701}