chrome/browser/permissions/permission_request.h - Issue 2382563003: Remove some more desktop infobar PNGs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_request.h

Issue 2382563003: Remove some more desktop infobar PNGs. (Closed)

Patch Set: pkasting review Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/permissions/permission_request.h

diff --git a/chrome/browser/permissions/permission_request.h b/chrome/browser/permissions/permission_request.h

index f9339ec1a1c13ff91ea846b7ec13029574911697..c5eed7e516f572fb2ad646c7471f5a444a535cad 100644

--- a/chrome/browser/permissions/permission_request.h

+++ b/chrome/browser/permissions/permission_request.h

@@ -68,8 +68,8 @@ class PermissionRequest {

virtual gfx::VectorIconId GetVectorIconId() const;

// The icon to use next to the message text fragment in the permission bubble.

- // Must be a valid icon of size 18x18.

- virtual int GetIconId() const = 0;

+ // TODO(estade): remove this in favor of GetVectorIconId().

+ virtual int GetIconId() const;

// Returns the shortened prompt text for this permission. Must be phrased

// as a heading, e.g. "Location", or "Camera". The permission bubble may