third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp - Issue 2382563002: Revert changes is the use of CompositingReasonOutOfFlowClipping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

Issue 2382563002: Revert changes is the use of CompositingReasonOutOfFlowClipping

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp ('K') | « third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

index e30b112a0200fc1eb6328806e5164ece24a8b69e..5863caad98d88f82e57f2085f61a1f5e2343c3d2 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

@@ -279,7 +279,7 @@ void CompositingRequirementsUpdater::updateRecursive(PaintLayer* ancestorLayer,

for (size_t i = 0; i < unclippedDescendantsToRemove.size(); i++)

unclippedDescendants.remove(unclippedDescendantsToRemove.at(unclippedDescendantsToRemove.size() - i - 1));

- if (layer->clipParent()) {

+ if (reasonsToComposite & CompositingReasonOutOfFlowClipping) {

// TODO(schenney): We only need to promote when the clipParent is not a descendant of the ancestor scroller,

// which we do not check for here. Hence we might be promoting needlessly.

unclippedDescendants.append(layer);