Issue 238253015: Finalize apk takes zipalign path as argument instead of hardcoding it

Issue 238253015: Finalize apk takes zipalign path as argument instead of hardcoding it (Closed)

Created:
6 years, 8 months ago by Yusuf

Modified:
6 years, 8 months ago

Reviewers:
cjhopman

CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Finalize apk takes zipalign path as argument instead of hardcoding it zipalign tool can be in sdk/tools or sdk/build-tools. This change looks for the right place and uses that instead of having it hardcoded inside android_sdk_root BUG=364655 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264842

Patch Set 1 #

Patch Set 2 : Put a condition to set the zipalign path to be empty for webview #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -6 lines)			Patch
	M	build/android/finalize_apk_action.gypi	View	1	2 chunks	+9 lines, -1 line	0 comments	Download
	M	build/android/gyp/finalize_apk.py	View		4 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/238253015/1

6 years, 8 months ago (2014-04-17 21:49:33 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 8 months ago (2014-04-17 23:51:42 UTC) #5

commit-bot: I haz the power

Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=66391

6 years, 8 months ago (2014-04-17 23:51:45 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/238253015/20001

6 years, 8 months ago (2014-04-18 17:28:04 UTC) #8

Message was sent while issue was closed.

Change committed as 264842

Expand Messages | Collapse Messages