Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 238253013: Introduce PushQuad and PopQuad for x64 port. (Closed)

Created:
6 years, 8 months ago by haitao.feng
Modified:
6 years, 7 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Introduce PushQuad and PopQuad for x64 port. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21080

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -13 lines) Patch
M src/x64/deoptimizer-x64.cc View 3 chunks +12 lines, -4 lines 0 comments Download
M src/x64/frames-x64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 10 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
PTAL. They are used to pushq an operand with kPointerSize or popq a 8-byte slot ...
6 years, 8 months ago (2014-04-17 13:22:57 UTC) #1
Toon Verwaest
lgtm
6 years, 7 months ago (2014-04-29 09:48:23 UTC) #2
haitao.feng
6 years, 7 months ago (2014-04-30 09:12:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21080 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698