Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6716)

Unified Diff: chrome/browser/performance_monitor/event.h

Issue 23825004: PerformanceMonitor: UMA alert for high browser CPU usage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/performance_monitor/constants.h ('k') | chrome/browser/performance_monitor/event_type.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/performance_monitor/event.h
diff --git a/chrome/browser/performance_monitor/event.h b/chrome/browser/performance_monitor/event.h
index b7666b49a52398ec568083c223196bdf81f62852..4bde2598ea507b8416f44818ecad765dce77d113 100644
--- a/chrome/browser/performance_monitor/event.h
+++ b/chrome/browser/performance_monitor/event.h
@@ -9,39 +9,9 @@
#include "base/time/time.h"
#include "base/values.h"
-namespace performance_monitor {
-
-// IMPORTANT: To add new events, please
-// - Place the new event above EVENT_NUMBER_OF_EVENTS.
-// - Add a member to the EventKeyChar enum in key_builder.cc.
-// - Add the appropriate messages in generated_resources.grd.
-// - Add the appropriate functions in
-// chrome/browser/ui/webui/performance_monitor/performance_monitor_l10n.h.
-enum EventType {
- EVENT_UNDEFINED,
-
- // Extension-Related events
- EVENT_EXTENSION_INSTALL,
- EVENT_EXTENSION_UNINSTALL,
- EVENT_EXTENSION_UPDATE,
- EVENT_EXTENSION_ENABLE,
- EVENT_EXTENSION_DISABLE,
-
- // Chrome's version has changed.
- EVENT_CHROME_UPDATE,
+#include "chrome/browser/performance_monitor/event_type.h"
- // Renderer-Failure related events; these correspond to the RENDERER_HANG
- // event, and the two termination statuses ABNORMAL_EXIT and PROCESS_KILLED,
- // respectively.
- EVENT_RENDERER_HANG,
- EVENT_RENDERER_CRASH,
- EVENT_RENDERER_KILLED,
-
- // Chrome did not shut down correctly.
- EVENT_UNCLEAN_EXIT,
-
- EVENT_NUMBER_OF_EVENTS
-};
+namespace performance_monitor {
const char* EventTypeToString(EventType event_type);
« no previous file with comments | « chrome/browser/performance_monitor/constants.h ('k') | chrome/browser/performance_monitor/event_type.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698