PerformanceMonitor: UMA alert for high browser CPU usage.

chrome/browser/performance_monitor/constants.h

Index: chrome/browser/performance_monitor/constants.h
diff --git a/chrome/browser/performance_monitor/constants.h b/chrome/browser/performance_monitor/constants.h
index 168baf22194ef083cc18f1f29c521d7c8cdf2aee..4d6c767e8562656b23c910daaa4682fddef0388f 100644
--- a/chrome/browser/performance_monitor/constants.h
+++ b/chrome/browser/performance_monitor/constants.h
@@ -21,6 +21,8 @@ extern const char kProcessChromeAggregate[];
 extern const char kStateChromeVersion[];
 extern const char kStateProfilePrefix[];
 
+// The interval the watched processes are sampled for performance metrics.
+const int kSampleInterval = 10;

[Yoyo Zhou, 2013/09/18 23:01:42]

Can this have units (like the constant below it)? Is this in seconds?

[oystein (OOO til 10th of July), 2013/09/19 14:16:24]

Done.

 // The default interval at which PerformanceMonitor performs its timed
 // collections; this can be overridden by using the kPerformanceMonitorGathering
 // switch with an associated (positive integer) value.
@@ -41,6 +43,8 @@ const int64 kBytesPerTerabyte = kBytesPerGigabyte * (1 << 10);
 const int64 kMicrosecondsPerMonth = base::Time::kMicrosecondsPerDay * 30;
 const int64 kMicrosecondsPerYear = base::Time::kMicrosecondsPerDay * 365;
 
+// Performance alert thresholds

[Yoyo Zhou, 2013/09/18 23:01:42]

Please document what this threshold is, and that it is a percent.

[oystein (OOO til 10th of July), 2013/09/19 14:16:24]

Done.

+const float kHighCPUUtilizationThreshold = 90.0f;
 }  // namespace performance_monitor
 
 #endif  // CHROME_BROWSER_PERFORMANCE_MONITOR_CONSTANTS_H_