PerformanceMonitor: UMA alert for high browser CPU usage.

chrome/browser/performance_monitor/process_metrics_history.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <limits>
+
+#include "base/logging.h"
+#include "base/process/process_metrics.h"
+
+#include "chrome/browser/performance_monitor/constants.h"
+#include "chrome/browser/performance_monitor/process_metrics_history.h"
+#if defined(OS_MACOSX)
+#include "content/public/browser/browser_child_process_host.h"
+#endif
+#include "content/public/browser/user_metrics.h"
+#include "content/public/common/process_type.h"
+
+namespace performance_monitor {
+
+ProcessMetricsHistory::ProcessMetricsHistory()
+    : process_handle_(0),
+      process_type_(content::PROCESS_TYPE_UNKNOWN),
+      last_update_sequence_(0) {
+  ResetCounters();
+}
+
+ProcessMetricsHistory::~ProcessMetricsHistory() {}
+
+void ProcessMetricsHistory::ResetCounters() {
+  min_cpu_usage_ = std::numeric_limits<double>::max();
+  accumulated_cpu_usage_ = 0.0;
+  accumulated_private_bytes_ = 0;
+  accumulated_shared_bytes_ = 0;
+  sample_count_ = 0;
+}
+
+void ProcessMetricsHistory::Initialize(base::ProcessHandle process_handle,
+                                       int process_type,
+                                       int initial_update_sequence) {
+  DCHECK(process_handle_ == 0);
+  process_handle_ = process_handle;
+  process_type_ = process_type;
+  last_update_sequence_ = initial_update_sequence;
+
+#if defined(OS_MACOSX)
+  process_metrics_.reset(base::ProcessMetrics::CreateProcessMetrics(
+      process_handle_, content::BrowserChildProcessHost::GetPortProvider()));
+#else
+  process_metrics_.reset(
+      base::ProcessMetrics::CreateProcessMetrics(process_handle_));
+#endif
+}
+
+void ProcessMetricsHistory::SampleMetrics() {
+  double cpu_usage = process_metrics_->GetCPUUsage();
+  min_cpu_usage_ = std::min(min_cpu_usage_, cpu_usage);
+  accumulated_cpu_usage_ += cpu_usage;
+
+  size_t private_bytes = 0;
+  size_t shared_bytes = 0;
+  if (!process_metrics_->GetMemoryBytes(&private_bytes, &shared_bytes))
+    LOG(WARNING) << "GetMemoryBytes returned NULL (platform-specific error)";
+
+  accumulated_private_bytes_ += private_bytes;
+  accumulated_shared_bytes_ += shared_bytes;
+
+  sample_count_++;

[Devlin, 2013/09/13 18:14:09]

nit: ++sample_count;

[oystein (OOO til 10th of July), 2013/09/13 20:41:55]

Why? This is a POD, not an iterator or another complex type with a pre/post
increment operator.

[Devlin, 2013/09/13 21:38:08]

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Preincrement_a...

[oystein (OOO til 10th of July), 2013/09/13 21:57:50]

Yeah that's my point. "For simple scalar (non-object) values there is no reason
to prefer one form and we allow either. For iterators and other template types,
use pre-increment.".

+}
+
+void ProcessMetricsHistory::EndOfCycle() {
+  RunPerformanceTriggers();
+  ResetCounters();
+}
+
+void ProcessMetricsHistory::RunPerformanceTriggers() {
+  // As an initial step, we only care about browser processes.
+  if (process_type_ != content::PROCESS_TYPE_BROWSER)
+    return;
+
+  // If CPU usage has consistently been above our threshold,
+  // we *may* have an issue.
+  if (min_cpu_usage_ > kHighCPUUtilizationThreshold) {

[Devlin, 2013/09/13 18:14:09]

Just FYI:

The different OSs report the CPU usage differently.  Linux and Mac will report
on a per-CPU basis, so having a CPU usage of 90% on these OSs is high, but not
terrible (in the initial testing for this, we saw readings into 200% - 400%
usage).  Windows, though, reports on a [0, 100] range.

I'm sure this can be accounted for (just as the different types and powers of
CPUs must be accounted for), but wanted to make sure you were aware.

[oystein (OOO til 10th of July), 2013/09/13 20:41:55]

That's fine; for this initial test we want to catch as few cases as possible,
and then gradually increase scope.

+    content::RecordAction(
+        content::UserMetricsAction("PerformanceMonitor.HighCPU.Browser"));
+  }
+}
+
+}  // namespace performance_monitor