Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2382463002: Fix analyzer error (Closed)

Created:
4 years, 2 months ago by vsm
Modified:
4 years, 2 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix analyzer error Analyzer was complaining that final field was not set. The other constructor does set, so doing so here as well. We may be able to remove this flag soon, but I see downstream uses. TBR=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/6144c10409c4285ec24a1eaa4d31699b874c301b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/dev_compiler/lib/src/analyzer/context.dart View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 3 (1 generated)
vsm
Committed patchset #1 (id:1) manually as 6144c10409c4285ec24a1eaa4d31699b874c301b (presubmit successful).
4 years, 2 months ago (2016-09-28 17:21:21 UTC) #2
Jennifer Messerly
4 years, 2 months ago (2016-09-28 17:49:05 UTC) #3
Message was sent while issue was closed.
lgtm. no big deal on the style issue, just an FYI

https://codereview.chromium.org/2382463002/diff/1/pkg/dev_compiler/lib/src/an...
File pkg/dev_compiler/lib/src/analyzer/context.dart (right):

https://codereview.chromium.org/2382463002/diff/1/pkg/dev_compiler/lib/src/an...
pkg/dev_compiler/lib/src/analyzer/context.dart:54: this.packageRoot: null,
style nit: ": null" part is not needed.

you do need "this.packageRoot," though :)

Powered by Google App Engine
This is Rietveld 408576698