Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3000)

Unified Diff: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

Issue 2382443007: Clean up NativeTheme (particularly CommonTheme). (Closed)
Patch Set: tdandersonreview Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
index da5705bea2c72f57d69f622dcd13ebe942eee94a..59a1fee2ac3066227661e6ada74bf2bcad1b542f 100644
--- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
+++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
@@ -848,10 +848,8 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver,
backgroundColor:(NSColor*)backgroundColor {
if ((self = [super initWithFrame:frameRect])) {
backgroundColor_.reset([backgroundColor retain]);
- // Use a color from Aura, since this button is not trying to look like a
- // native control.
- SkColor hoverColor = ui::GetAuraColor(
- ui::NativeTheme::kColorId_ButtonHoverBackgroundColor, nullptr);
+ // TODO(estade): share this with the Views version of this code.
sky 2016/10/03 16:12:05 Why not move it now? Maybe in c/b/ui/profile_choos
Evan Stade 2016/10/03 19:46:44 I suspect we want to refactor this code to make it
+ SkColor hoverColor = SkColorSetRGB(0xEA, 0xEA, 0xEA);
hoverColor_.reset([skia::SkColorToSRGBNSColor(hoverColor) retain]);
[self setBordered:NO];

Powered by Google App Engine
This is Rietveld 408576698