Clean up NativeTheme (particularly CommonTheme).

ui/views/controls/menu/menu_item_view.cc

Index: ui/views/controls/menu/menu_item_view.cc
diff --git a/ui/views/controls/menu/menu_item_view.cc b/ui/views/controls/menu/menu_item_view.cc
index d36350e12246dc611b8de88afb5a0ec8f7d6755a..a405cb24ced6de584d4147734675ef78c1d43e48 100644
--- a/ui/views/controls/menu/menu_item_view.cc
+++ b/ui/views/controls/menu/menu_item_view.cc
@@ -787,9 +787,9 @@ void MenuItemView::PaintButton(gfx::Canvas* canvas, PaintButtonMode mode) {
     bool emphasized = delegate &&
                       delegate->GetShouldUseDisabledEmphasizedForegroundColor(
                           GetCommand());
-    color_id = emphasized ?
-        ui::NativeTheme::kColorId_DisabledEmphasizedMenuItemForegroundColor :
-        ui::NativeTheme::kColorId_DisabledMenuItemForegroundColor;
+    color_id = emphasized
+                   ? ui::NativeTheme::kColorId_EnabledMenuItemForegroundColor

[Evan Stade, 2016/09/30 18:02:36]

it really seems like this is just a special case where we want to have a
disabled menu item but have it use the normal text color (i.e. app menu >
history headers). It doesn't deserve its own native theme ID.

[tdanderson, 2016/09/30 21:00:56]

SG, but if you're changing this then consider also changing the name of
GetShouldUseDisabledEmphasizedForegroundColor() on 788 to something else.

Also, I'm assuming that by changing this it doesn't change the fact that the
text appears bolded?

[Evan Stade, 2016/09/30 22:19:00]

held my nose and changed it
no, it does not change the boldness

+                   : ui::NativeTheme::kColorId_DisabledMenuItemForegroundColor;
   }
   SkColor fg_color = native_theme->GetSystemColor(color_id);
   SkColor override_foreground_color;