Clean up NativeTheme (particularly CommonTheme).

ui/views/controls/label.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/label.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <cmath>
@@ skipping 578 matching lines @@
 void Label::UpdateColorsFromTheme(const ui::NativeTheme* theme) {
   if (!enabled_color_set_) {
     requested_enabled_color_ = theme->GetSystemColor(
         ui::NativeTheme::kColorId_LabelEnabledColor);
   }
   if (!disabled_color_set_) {
     requested_disabled_color_ = theme->GetSystemColor(
         ui::NativeTheme::kColorId_LabelDisabledColor);
   }
   if (!background_color_set_) {
-    background_color_ = theme->GetSystemColor(
-        ui::NativeTheme::kColorId_LabelBackgroundColor);
+    background_color_ =
+        theme->GetSystemColor(ui::NativeTheme::kColorId_DialogBackground);

[sky, 2016/10/03 16:12:05]

Why are you preferring dialogbackground to labelbackground? Using dialog sort of
implies labels are only used in dialogs. Maybe DialogBackground should be
WindowBackground?

[Evan Stade, 2016/10/03 19:46:44]

I'd say it only implies labels /can/ be used in dialogs, which is a fair
assumption. The label's text color has to be readable on a dialog background,
and that's what this is ensuring.
good question, I don't have a particular reason to prefer either dialog or
window, but as long as they're pretty close (and in many cases they're the same
thing) it should be ok, as this isn't actually drawn, it's just for the auto
color readability stuff.

   }
   RecalculateColors();
 }
 
 bool Label::ShouldShowDefaultTooltip() const {
   const gfx::Size text_size = GetTextSize();
   const gfx::Size size = GetContentsBounds().size();
   return !obscured() && (text_size.width() > size.width() ||
                          (multi_line() && text_size.height() > size.height()));
 }
 
 }  // namespace views