Clean up NativeTheme (particularly CommonTheme).

chrome/browser/ui/libgtk2ui/native_theme_gtk2.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/libgtk2ui/native_theme_gtk2.h"
 
 #include <gtk/gtk.h>
 
 #include "chrome/browser/ui/libgtk2ui/chrome_gtk_frame.h"
 #include "chrome/browser/ui/libgtk2ui/chrome_gtk_menu_subclasses.h"
@@ skipping 243 matching lines @@
     case kColorId_FocusedMenuItemBackgroundColor:
       return GetBGColor(GetMenuItem(), SELECTED);
 #else
     case kColorId_SelectedMenuItemForegroundColor:
       return GetTextColor(GetMenuItem(), PRELIGHT);
     case kColorId_FocusedMenuItemBackgroundColor:
       return GetBGColor(GetMenuItem(), PRELIGHT);
 #endif
 
     case kColorId_EnabledMenuItemForegroundColor:
-    case kColorId_DisabledEmphasizedMenuItemForegroundColor:
       return GetTextColor(GetMenuItem(), NORMAL);
     case kColorId_DisabledMenuItemForegroundColor:
       return GetTextColor(GetMenuItem(), INSENSITIVE);
-    case kColorId_HoverMenuItemBackgroundColor:
-      return GetBGColor(GetMenuItem(), PRELIGHT);
     case kColorId_FocusedMenuButtonBorderColor:
       return GetBGColor(GetEntry(), NORMAL);
     case kColorId_HoverMenuButtonBorderColor:
       return GetTextAAColor(GetEntry(), PRELIGHT);
     case kColorId_MenuBorderColor:
     case kColorId_EnabledMenuButtonBorderColor:
     case kColorId_MenuSeparatorColor: {
       return GetTextColor(GetMenuItem(), INSENSITIVE);
     }
     case kColorId_MenuBackgroundColor:
       return GetBGColor(GetMenu(), NORMAL);
 
     // Label
     case kColorId_LabelEnabledColor:
       return GetTextColor(GetEntry(), NORMAL);
     case kColorId_LabelDisabledColor:
       return GetTextColor(GetLabel(), INSENSITIVE);
-    case kColorId_LabelBackgroundColor:
-      return GetBGColor(GetWindow(), NORMAL);
 
     // Link
     case kColorId_LinkDisabled:
       return SkColorSetA(GetSystemColor(kColorId_LinkEnabled), 0xBB);
     case kColorId_LinkEnabled: {
       SkColor link_color = SK_ColorTRANSPARENT;
       GetChromeStyleColor("link-color", &link_color);
       if (link_color != SK_ColorTRANSPARENT)
         return link_color;
       // Default color comes from gtklinkbutton.c.
       return SkColorSetRGB(0x00, 0x00, 0xEE);
     }
     case kColorId_LinkPressed:
       return SK_ColorRED;
 
     // Button
-    case kColorId_ButtonBackgroundColor:
-      return GetBGColor(GetButton(), NORMAL);
     case kColorId_ButtonEnabledColor:
       return GetTextColor(GetButton(), NORMAL);
     case kColorId_BlueButtonEnabledColor:
       return GetTextColor(GetBlueButton(), NORMAL);
     case kColorId_ButtonDisabledColor:
       return GetTextColor(GetButton(), INSENSITIVE);
     case kColorId_BlueButtonDisabledColor:
       return GetTextColor(GetBlueButton(), INSENSITIVE);
-    case kColorId_ButtonHighlightColor:
-      return GetBaseColor(GetButton(), SELECTED);
     case kColorId_ButtonHoverColor:
       return GetTextColor(GetButton(), PRELIGHT);
     case kColorId_BlueButtonHoverColor:
       return GetTextColor(GetBlueButton(), PRELIGHT);
-    case kColorId_ButtonHoverBackgroundColor:
-      return GetBGColor(GetButton(), PRELIGHT);
     case kColorId_BlueButtonPressedColor:
       return GetTextColor(GetBlueButton(), ACTIVE);
     case kColorId_BlueButtonShadowColor:
       return SK_ColorTRANSPARENT;
-      // return GetTextColor(GetButton(), NORMAL);

[tdanderson, 2016/09/30 21:00:56]

strange...

     case kColorId_ProminentButtonColor:
       return GetSystemColor(kColorId_LinkEnabled);
     case kColorId_TextOnProminentButtonColor:
       return GetTextColor(GetLabel(), SELECTED);
     case kColorId_ButtonPressedShade:
       return SK_ColorTRANSPARENT;
 
     // Textfield
     case kColorId_TextfieldDefaultColor:
       return GetTextColor(GetEntry(), NORMAL);
@@ skipping 246 matching lines @@
 
   if (!fake_menu_item) {
     fake_menu_item = gtk_custom_menu_item_new();
     gtk_menu_shell_append(GTK_MENU_SHELL(GetMenu()), fake_menu_item);
   }
 
   return fake_menu_item;
 }
 
 }  // namespace libgtk2ui