Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2382423002: minica.py: don't encode default critical=False values (Closed)

Created:
4 years, 2 months ago by mattm
Modified:
4 years, 2 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

minica.py: don't encode default critical=False values Also add some helper code to make updating the ocsp-test-root easier. BUG=none Committed: https://crrev.com/3b4376f1d53c435d13dbcc9330c824292a793b2a Cr-Commit-Position: refs/heads/master@{#422529}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -35 lines) Patch
M net/data/ssl/certificates/ocsp-test-root.pem View 3 chunks +18 lines, -18 lines 0 comments Download
M net/data/ssl/scripts/crlsetutil.py View 2 chunks +13 lines, -2 lines 0 comments Download
M net/tools/testserver/minica.py View 1 5 chunks +35 lines, -12 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
mattm
4 years, 2 months ago (2016-10-01 01:59:53 UTC) #5
davidben
lgtm https://codereview.chromium.org/2382423002/diff/1/net/tools/testserver/minica.py File net/tools/testserver/minica.py (right): https://codereview.chromium.org/2382423002/diff/1/net/tools/testserver/minica.py#newcode446 net/tools/testserver/minica.py:446: return ' '.join(['0x%02x,'%ord(c) for c in s]) Nit: ...
4 years, 2 months ago (2016-10-01 17:47:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382423002/20001
4 years, 2 months ago (2016-10-03 20:10:34 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 21:07:37 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 21:11:04 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3b4376f1d53c435d13dbcc9330c824292a793b2a
Cr-Commit-Position: refs/heads/master@{#422529}

Powered by Google App Engine
This is Rietveld 408576698