Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2382373002: Update chooser row view when mouse click down and move over rows (Closed)

Created:
4 years, 2 months ago by juncai
Modified:
4 years, 2 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update chooser row view when mouse click down and move over rows This CL adds code to update row view in the chooser when mouse button is down and moves over rows. BUG=645693 Committed: https://crrev.com/79e7fbecef8cae765f7ff396db054a3cc83c8daa Cr-Commit-Position: refs/heads/master@{#422850}

Patch Set 1 : update chooser row view when mouse click down and move over rows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
juncai
Please take a look.
4 years, 2 months ago (2016-09-30 20:55:27 UTC) #4
Robert Sesek
lgtm
4 years, 2 months ago (2016-10-04 16:05:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2382373002/1
4 years, 2 months ago (2016-10-04 16:59:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 17:42:14 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 17:45:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79e7fbecef8cae765f7ff396db054a3cc83c8daa
Cr-Commit-Position: refs/heads/master@{#422850}

Powered by Google App Engine
This is Rietveld 408576698