Fix issue with font family and language in accessibility tree

Fix issue with font family and language in accessibility tree

We were incorrectly not exposing the font family and language if the
change happened on a node that we happened to ignore in the
accessibility tree.

See related bug 651614 where I'm hoping to get rid of or at least simplify
the concept of "ignored" because it causes problems like this

BUG=651917
Committed: https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463
Cr-Commit-Position: refs/heads/master@{#423316}

[dmazzoni, 2016-09-30 19:54:03]

The CQ bit was checked by dmazzoni@chromium.org to run a CQ dry run

[dmazzoni, 2016-09-30 19:54:08]

dmazzoni@chromium.org changed reviewers:
+ nektar@chromium.org

[commit-bot: I haz the power, 2016-09-30 19:54:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nektarios, 2016-09-30 20:14:37]

ParentObjectUnignored
Could we add this on WebAXObject itself? Or is this a temporary fix until your
refactoring with accessibilityIsIgnored is done.

IsParentUnignoredOf
Where is this function used? Is this added for a future change?

/content/test/data/accessibility/css/language-expected-win.txt
+++ROLE_SYSTEM_STATICTEXT language:fr-FR name='Comment allez-vous?'
language:fr-FR ia2_hypertext='Comment allez-vous?'
Strange, why is the language attribute listed twice?

[commit-bot: I haz the power, 2016-09-30 21:00:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 21:00:34]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dmazzoni, 2016-10-03 03:57:27]

On 2016/09/30 20:14:37, nektarios wrote:
> ParentObjectUnignored
> Could we add this on WebAXObject itself? Or is this a temporary fix until your
> refactoring with accessibilityIsIgnored is done.

No, I think that would just make it worse. I've already started refactoring to
get rid of it.

> IsParentUnignoredOf
> Where is this function used? Is this added for a future change?

I didn't add this function, I just updated an existing helper function to share
a few lines
of code. It's used to identify weird corner cases where a node is a child of the
current
node, but the current node is not the child's parent. One example is a table
cell, which is
a child of both a row and column.

> /content/test/data/accessibility/css/language-expected-win.txt
> +++ROLE_SYSTEM_STATICTEXT language:fr-FR name='Comment allez-vous?'
> language:fr-FR ia2_hypertext='Comment allez-vous?'
> Strange, why is the language attribute listed twice?

I think one is from the AXStringAttribute array and one is from the IAccessible2
attributes string,
they both just look the same in the dump.

[nektarios, 2016-10-03 14:58:30]

I don't know if you have the time to change one of the language attributes to
ia2_language, just to make it clear in the test expectations.

[nektarios, 2016-10-03 14:58:36]

lgtm

[dmazzoni, 2016-10-05 21:13:57]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-10-05 21:13:58]

The patchset sent to the CQ was uploaded after l-g-t-m from nektar@chromium.org
Link to the patchset: https://codereview.chromium.org/2382343002/#ps20001
(title: "Fix win expectation")

[commit-bot: I haz the power, 2016-10-05 21:14:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 22:28:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 22:31:15]

Description was changed from

==========
Fix issue with font family and language in accessibility tree

We were incorrectly not exposing the font family and language if the
change happened on a node that we happened to ignore in the
accessibility tree.

See related bug 651614 where I'm hoping to get rid of or at least simplify
the concept of "ignored" because it causes problems like this

BUG=651917
==========

to

==========
Fix issue with font family and language in accessibility tree

We were incorrectly not exposing the font family and language if the
change happened on a node that we happened to ignore in the
accessibility tree.

See related bug 651614 where I'm hoping to get rid of or at least simplify
the concept of "ignored" because it causes problems like this

BUG=651917

Committed: https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463
Cr-Commit-Position: refs/heads/master@{#423316}
==========

[commit-bot: I haz the power, 2016-10-05 22:31:16]

Patchset 2 (id:??) landed as
https://crrev.com/571683bf6f39de12e3269fa493c68cc410602463
Cr-Commit-Position: refs/heads/master@{#423316}