Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 238233002: Reduce auto_stub.py by removing python 2.6 support code. (Closed)

Created:
6 years, 8 months ago by M-A Ruel
Modified:
6 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Reduce auto_stub.py by removing python 2.6 support code. This makes this file even easier to read and python 2.6 support is not needed anymore. R=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=265799

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unneeded pylint disabling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -61 lines) Patch
M testing_support/auto_stub.py View 1 3 chunks +6 lines, -61 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
M-A Ruel
6 years, 8 months ago (2014-04-14 23:43:00 UTC) #1
M-A Ruel
ping
6 years, 8 months ago (2014-04-22 13:33:37 UTC) #2
iannucci
lgtm https://chromiumcodereview.appspot.com/238233002/diff/1/testing_support/auto_stub.py File testing_support/auto_stub.py (right): https://chromiumcodereview.appspot.com/238233002/diff/1/testing_support/auto_stub.py#newcode73 testing_support/auto_stub.py:73: # pylint: disable=E1101 is this still needed?
6 years, 8 months ago (2014-04-24 00:34:21 UTC) #3
M-A Ruel
https://chromiumcodereview.appspot.com/238233002/diff/1/testing_support/auto_stub.py File testing_support/auto_stub.py (right): https://chromiumcodereview.appspot.com/238233002/diff/1/testing_support/auto_stub.py#newcode73 testing_support/auto_stub.py:73: # pylint: disable=E1101 On 2014/04/24 00:34:21, iannucci wrote: > ...
6 years, 8 months ago (2014-04-24 00:41:12 UTC) #4
M-A Ruel
The CQ bit was checked by maruel@chromium.org
6 years, 8 months ago (2014-04-24 00:41:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/238233002/20001
6 years, 8 months ago (2014-04-24 00:41:46 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 00:44:29 UTC) #7
Message was sent while issue was closed. 
Change committed as 265799

Powered by Google App Engine
This is Rietveld 408576698