Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: infra/bots/recipe_modules/vars/api.py

Issue 2382313003: Stop uploading nanobench results on Valgrind bot (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/bots/recipe_modules/vars/api.py
diff --git a/infra/bots/recipe_modules/vars/api.py b/infra/bots/recipe_modules/vars/api.py
index b2b51b30ac973f210c750515c2116ac78a6bdd92..5786d436bf74e7f3dac21472abf4acd4500146e2 100644
--- a/infra/bots/recipe_modules/vars/api.py
+++ b/infra/bots/recipe_modules/vars/api.py
@@ -144,4 +144,19 @@ class SkiaVarsApi(recipe_api.RecipeApi):
@property
def upload_perf_results(self):
# TODO(borenet): Move this into the swarm_perf recipe.
- return ('Release' in self.m.properties['buildername'])
+ if 'Release' not in self.m.properties['buildername']:
+ return False
+ skip_upload_bots = [
+ 'ASAN',
+ 'Coverage',
+ 'MSAN',
+ 'TSAN',
+ 'UBSAN',
+ 'Valgrind',
+ ]
+ upload_perf_results = True
+ for s in skip_upload_bots:
+ if s in self.m.properties['buildername']:
+ upload_perf_results = False
+ break
+ return upload_perf_results
« no previous file with comments | « no previous file | infra/bots/recipes/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698