LayoutTests/svg/animations/repeatn-event-2a.svg - Issue 23823006: [SVG] Handle repeat(n) event for svg animations

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/animations/repeatn-event-2a.svg

Issue 23823006: [SVG] Handle repeat(n) event for svg animations (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/svg/animations/repeatn-event-1d.svg ('K') | « LayoutTests/svg/animations/repeatn-event-1d-expected.svg ('k') | LayoutTests/svg/animations/repeatn-event-2a-expected.svg » ('j') | Source/core/svg/animation/SVGSMILElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="UTF-8"?>

	2 <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1 Tiny//EN" "http://www.w3.org/Graphics/ SVG/1.1/DTD/svg11-tiny.dtd">

	3 <svg onload="loaded()" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://ww w.w3.org/1999/xlink">

	4 <g>

	5 <animate id="anim" attributeName="visibility" to="visible" begin="0s" dur="2 s" repeatCount="4"/>

	6 <rect x="0" y="0" width="100" height="100" fill="green">
	pdr. 2013/09/03 17:48:14 Does this pass? Should this first one be fill="red Does this pass? Should this first one be fill="red" and the set to="green"? pavane 2013/09/03 19:00:52 repeat(0) should not be fired. So, i added a negat Show quoted text On 2013/09/03 17:48:14, pdr wrote: > Does this pass? Should this first one be fill="red" and the set to="green"? repeat(0) should not be fired. So, i added a negative test. Green first and then if it turns red, it should fail.
	7 <set attributeName="fill" to="red" begin="anim.repeat(0)"/>

	8 </rect>

	9 <rect x="200" y="0" width="100" height="100" fill="red">

	10 <set attributeName="fill" to="green" begin="anim.repeat(1)"/>

	11 </rect>

	12 <rect x="0" y="200" width="100" height="100" fill="red">

	13 <set attributeName="fill" to="green" begin="anim.repeat(2)"/>

	14 </rect>

	15 <rect x="200" y="200" width="100" height="100" fill="red">

	16 <set attributeName="fill" to="green" begin="anim.repeat(3)"/>

	17 </rect>

	18 </g>

	19 <script>

	20 if (window.testRunner)

	21 testRunner.waitUntilDone();

	22

	23 function loaded() {

	24 document.documentElement.setCurrentTime(8);

	25

	26 if (window.testRunner)

	27 setTimeout(function(){testRunner.notifyDone();}, 100);

	28 }

	29 </script>

	30 </svg>

OLD	NEW