Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Side by Side Diff: net/disk_cache/backend_unittest.cc

Issue 23823002: Don't doom the wrong simple cache entry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase to CQed version upstream Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | net/disk_cache/entry_unittest.cc » ('j') | net/disk_cache/entry_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/file_util.h" 6 #include "base/file_util.h"
7 #include "base/metrics/field_trial.h" 7 #include "base/metrics/field_trial.h"
8 #include "base/port.h" 8 #include "base/port.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/strings/stringprintf.h" 10 #include "base/strings/stringprintf.h"
(...skipping 3173 matching lines...) Expand 10 before | Expand all | Expand 10 after
3184 SetSimpleCacheMode(); 3184 SetSimpleCacheMode();
3185 BackendDoomRecent(); 3185 BackendDoomRecent();
3186 } 3186 }
3187 3187
3188 TEST_F(DiskCacheBackendTest, SimpleDoomBetween) { 3188 TEST_F(DiskCacheBackendTest, SimpleDoomBetween) {
3189 SetSimpleCacheMode(); 3189 SetSimpleCacheMode();
3190 BackendDoomBetween(); 3190 BackendDoomBetween();
3191 } 3191 }
3192 3192
3193 // See http://crbug.com/237450. 3193 // See http://crbug.com/237450.
3194 // TODO(gavinp): Consider enabling this test again when 3194 TEST_F(DiskCacheBackendTest, FLAKY_SimpleCacheDoomAll) {
3195 // https://codereview.chromium.org/23823002/ lands.
3196 TEST_F(DiskCacheBackendTest, DISABLED_SimpleCacheDoomAll) {
3197 SetSimpleCacheMode(); 3195 SetSimpleCacheMode();
3198 BackendDoomAll(); 3196 BackendDoomAll();
3199 } 3197 }
3200 3198
3201 TEST_F(DiskCacheBackendTest, FLAKY_SimpleCacheAppCacheOnlyDoomAll) { 3199 TEST_F(DiskCacheBackendTest, FLAKY_SimpleCacheAppCacheOnlyDoomAll) {
3202 SetCacheType(net::APP_CACHE); 3200 SetCacheType(net::APP_CACHE);
3203 SetSimpleCacheMode(); 3201 SetSimpleCacheMode();
3204 BackendDoomAll(); 3202 BackendDoomAll();
3205 } 3203 }
3206 3204
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
3447 void* iter = NULL; 3445 void* iter = NULL;
3448 size_t count = 0; 3446 size_t count = 0;
3449 ASSERT_TRUE(EnumerateAndMatchKeys(-1, &iter, &keys_to_match, &count)); 3447 ASSERT_TRUE(EnumerateAndMatchKeys(-1, &iter, &keys_to_match, &count));
3450 cache_->EndEnumeration(&iter); 3448 cache_->EndEnumeration(&iter);
3451 3449
3452 EXPECT_EQ(key_pool.size(), count); 3450 EXPECT_EQ(key_pool.size(), count);
3453 EXPECT_TRUE(keys_to_match.empty()); 3451 EXPECT_TRUE(keys_to_match.empty());
3454 } 3452 }
3455 3453
3456 #endif // !defined(OS_WIN) 3454 #endif // !defined(OS_WIN)
OLDNEW
« no previous file with comments | « no previous file | net/disk_cache/entry_unittest.cc » ('j') | net/disk_cache/entry_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698